Skip to content

Remove worked examples from Skill objects in asset download script.#5986

Merged
BenHenning merged 3 commits into
introduce-asset-download-scriptfrom
remove-worked-examples
Oct 3, 2025
Merged

Remove worked examples from Skill objects in asset download script.#5986
BenHenning merged 3 commits into
introduce-asset-download-scriptfrom
remove-worked-examples

Conversation

@seanlip

@seanlip seanlip commented Oct 2, 2025

Copy link
Copy Markdown
Member

Explanation

Removes worked example from Skill objects in asset download script, and updates the state schema compatibility to v57.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) (N/A)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@seanlip
seanlip requested a review from a team as a code owner October 2, 2025 17:05
@seanlip
seanlip requested review from BenHenning and removed request for a team October 2, 2025 17:05

@BenHenning BenHenning left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seanlip! I'm assuming this fixes most of the issues once the backup server has updated data and other fixes. Perhaps enough?

Separately, we should also remove worked_examples from the app's proto (by replacing it with a reserved 4 line with a comment explaining what it was):

// A list of worked examples to present to the learner.
repeated SubtitledHtml worked_example = 4;

Fortunately the working proto API (https://github.com/oppia/oppia-proto-api/blob/introduce-proto-api-v1/org/oppia/proto/v1/structure/revision_card.proto) never added worked examples so no change is needed there.

Finally, I do expect CI to fail here but we don't need to block on that to merge.

@BenHenning BenHenning assigned seanlip and unassigned BenHenning Oct 2, 2025
@seanlip
seanlip requested a review from a team as a code owner October 3, 2025 01:12
@seanlip
seanlip requested review from BenHenning and removed request for a team October 3, 2025 01:12
@seanlip

seanlip commented Oct 3, 2025

Copy link
Copy Markdown
Member Author

Thanks @BenHenning -- have made the changes.

Thanks @seanlip! I'm assuming this fixes most of the issues once the backup server has updated data and other fixes. Perhaps enough?

I'm not quite sure what your question means here, but we can discuss in the call.

Finally, I do expect CI to fail here but we don't need to block on that to merge.

It seems to be stalled, actually -- everything is "queued". Not sure why.

@seanlip seanlip assigned BenHenning and unassigned seanlip Oct 3, 2025
@BenHenning
BenHenning merged commit be13fde into introduce-asset-download-script Oct 3, 2025
0 of 20 checks passed
@BenHenning
BenHenning deleted the remove-worked-examples branch October 3, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants