[69526] Text overflow in Baseline modal banner#23431
Open
bsatarnejad wants to merge 2 commits into
Open
Conversation
bsatarnejad
changed the title
bsatarnejad
force-pushed
the
69526-text-overflow-in-baseline-modal-banner
branch
from
d2ea70e to
54a1190
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes horizontal overflow in Enterprise upsell/banner button rows by allowing the buttons to wrap and by using consistent flex spacing.
Changes:
- Enables wrapping for
EnterpriseEdition::UpsellButtonsComponent. - Replaces per-button left margins with a shared CSS
gap. - Allows the banner content grid column to shrink via
minmax(0, 1fr).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
app/components/enterprise_edition/upsell_buttons_component.rb |
Adds wrapping and a CSS hook for upsell button layout spacing. |
app/components/enterprise_edition/banner_component.sass |
Updates banner grid sizing and defines the button-row gap. |
HDinger
reviewed
May 29, 2026
| grid-auto-flow: column | ||
| grid-template-areas: "visual content dismiss" | ||
| grid-template-columns: min-content 1fr min-content | ||
| grid-template-columns: min-content minmax(0, 1fr) min-content |
Contributor
There was a problem hiding this comment.
What is that change needed for? As far as I can tell, it works without it but maybe I miss something.. I am a bit worried about possible side effects on other banners which are not inside a dialog context
Contributor
Author
There was a problem hiding this comment.
I've changed it to let the content shrink in constrained layouts, but it is not needed for this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/69526
What are you trying to accomplish?
The upsell button row now wraps instead of overflowing horizontally. Spacing between buttons is handled with a flex gap, so wrapped buttons keep consistent spacing without relying on per-button left margins.
Screenshotss