[#74683] Simplify story point metric#23061
Merged
myabc merged 4 commits intoMay 5, 2026
Merged
Conversation
5de5889 to
b0bf56e
Compare
991d8c6 to
048ded1
Compare
HDinger
approved these changes
May 5, 2026
31 tasks
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Backlogs-specific responsive story-point behavior from the generic OpenProject::Common::WorkPackageCardComponent styling, and moves the story point accessibility behavior into the Backlogs-specific StoryPointsComponent. Visually, Backlogs cards now show only the numeric story point value, while screen readers receive the full localized “N story points” label.
Changes:
- Updated
Backlogs::StoryPointsComponentto render a visually-visible number (aria-hidden) plus a screen-reader-only localized label. - Simplified the common work package card metric layout CSS by dropping the Backlogs container-query override and tightening metric column sizing/alignment.
- Adjusted Backlogs component specs to assert the new accessibility-oriented markup instead of
"N points"text.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
modules/backlogs/app/components/backlogs/story_points_component.html.erb |
Renders numeric story points visually and provides SR-only localized label. |
app/components/open_project/common/work_package_card_component.sass |
Removes Backlogs container-query overrides; adjusts metric column sizing and alignment. |
app/components/open_project/common/work_package_card_component.rb |
Removes card_classes helper in favor of template-driven class handling. |
app/components/open_project/common/work_package_card_component.html.erb |
Applies conditional metric class via grid_layout call instead of card_classes. |
modules/backlogs/spec/components/backlogs/story_points_component_spec.rb |
Updates specs to verify visible number and SR-only label output. |
modules/backlogs/spec/components/backlogs/work_package_card_component_spec.rb |
Updates card metric expectations to match new story points markup. |
modules/backlogs/spec/components/backlogs/work_package_card_box_item_component_spec.rb |
Updates metric forwarding expectations for Backlogs card items. |
modules/backlogs/spec/components/backlogs/sprint_component_spec.rb |
Updates story point assertions across sprint-rendered cards. |
modules/backlogs/spec/components/backlogs/inbox_component_spec.rb |
Updates story point assertions across inbox-rendered cards. |
modules/backlogs/spec/components/backlogs/bucket_component_spec.rb |
Updates story point assertions for bucket-rendered cards. |
Base automatically changed from
code-maintenance/74088-backlog-sprints-component-renaming
to
dev
May 5, 2026 13:14
Makes `WorkPackageCardComponent` apply correct classes to grid areas.
Render story point card metrics as numeric-only text while keeping the full localized story point label available to assistive technology. Remove the Backlogs-specific container query from the generic work package card styles and cover the accessible metric behavior in component specs. https://community.openproject.org/wp/74683
048ded1 to
50e7a24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is based off #22936
Ticket
https://community.openproject.org/wp/74683
What are you trying to accomplish?
Remove the Backlogs-specific responsive story-points behavior from the generic work package card styles. Backlogs cards now show only the numeric story point metric visually, while assistive technology still receives the full localized story point label.
Screenshots
What approach did you choose and why?
The generic
WorkPackageCardComponentshould not depend on the Backlogs page container, so the container-query override was removed from its Sass. The Backlogs story-points component now owns the accessibility behavior by rendering the numeric value asaria-hiddenand adding a screen-reader-onlybacklogs.story_pointslabel.Merge checklist