Skip to content

ubusd_id: use GRND_INSECURE to avoid blocking boot on getrandom() #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openwrt-bot merged 1 commit into from
Jun 28, 2026
+10 −1
Merged

ubusd_id: use GRND_INSECURE to avoid blocking boot on getrandom() #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ubusd_id.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
#include <fcntl.h>
#ifdef __linux__
#include <sys/random.h>
/* Added in Linux 5.6; define it in case the libc headers are older. */
#ifndef GRND_INSECURE
#define GRND_INSECURE 0x0004
#endif
#endif
#include <libubox/avl-cmp.h>

Expand All @@ -30,7 +34,12 @@ static int random_fd = -1;
static ssize_t read_random(void *buf, size_t len)
{
#ifdef __linux__
return getrandom(buf, len, 0);
/*
* IDs only need to be hard to guess, not crypto-strong.
* GRND_INSECURE returns bytes without blocking on the CRNG, so
* ubusd does not stall boot on boards whose pool seeds late.
*/
return getrandom(buf, len, GRND_INSECURE);
#else
if (random_fd < 0) {
random_fd = open("/dev/urandom", O_RDONLY);
Expand Down
Loading