fix discarded-qualifiers warnings with GCC 16+#82
Open
graysky2 wants to merge 1 commit into
Open
Conversation
GCC 16+ builtins for strchr/strstr are const-correct: they return const char * when passed a const char * argument. Also, accessing a char * struct member through a const-qualified pointer yields char * const. Fix all three instances: - handler: netifd_handler_parse_config cast strchr result to char * since the underlying buffer is mutable (written via str_cur) - iprule: rule_cmp locals str1/str2 declared as const char * - system-linux: system_add_devtype local index declared as const char * Signed-off-by: John Audia <therealgraysky@proton.me>
graysky2
added a commit
to graysky2/openwrt
that referenced
this pull request
May 26, 2026
Add pending openwrt/netifd#82 This is needed for openwrt#23194 Signed-off-by: John Audia <therealgraysky@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 16+ builtins for strchr/strstr are const-correct: they return const char * when passed a const char * argument. Also, accessing a char * struct member through a const-qualified pointer yields char * const. Fix all three instances: