interface: retry extdev claim on ifindex update#78
Open
dm1trys wants to merge 1 commit into
Open
Conversation
External devices can briefly exist without a resolvable ifindex. If an autostart interface tries to claim such a device, the claim currently fails with DEVICE_CLAIM_FAILED and the interface may stay down even after the device later receives a valid ifindex. Treat this specific external/no-ifindex claim failure as transient and retry interface setup when the device emits DEV_EVENT_UPDATE_IFINDEX. This keeps genuine claim failures unchanged while fixing recreated external devices such as tunnel interfaces. Signed-off-by: Dmitry Slavgorodskiy <7873029+dm1trys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry autostart setup for external devices once a valid ifindex
appears, and avoid treating the transient external/no-ifindex
claim failure as terminal.
Problem
External devices can briefly exist without a resolvable ifindex.
If an autostart interface tries to claim such a device, netifd
can report DEVICE_CLAIM_FAILED and leave the interface down even
after the device later receives a valid ifindex.
Fix
external-device/no-ifindex case
Notes
This keeps genuine claim failures unchanged while fixing
recreated external devices such as tunnel interfaces.