Add predictor MHC context metadata#210
Merged
Merged
Conversation
f5bea86 to
cde3692
Compare
cde3692 to
8633db2
Compare
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kind_support()metadata with direct per-kindmhc_dependenceandmhc_classfields.best_alleleas attribution.Root Cause
MHCflurry’s presentation predictor is genotype/haplotype-aware, but the mhctools wrapper was calling it one allele at a time and exposing those outputs as if presentation were per-allele. That changed the wrapper contract relative to the upstream model and made
Kind.pMHC_presentationsemantics ambiguous for downstream tools.Validation
./lint.sh./test.sh(414 passed, 9 skipped, 2 xfailed)Fixes #208
Fixes #209