Fix stale RELEASING.md (deploy.sh, not setup.py sdist upload)#55
Merged
Conversation
…pload The release steps referenced a deleted setup.py, an obsolete pandoc/pypandoc readme step, and `python setup.py sdist upload` (deprecated; PyPI rejects it). Update to the real process: bump datacache/version.py, then ./deploy.sh (lint + test + build + twine upload).
Coverage Report for CI Build 27784211071Coverage remained the same at 73.451%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
1 similar comment
Coverage Report for CI Build 27784211071Coverage remained the same at 73.451%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASING.md was stale on every step:
setup.pyfor the version bump — but the project moved topyproject.toml; the version lives indatacache/version.py,pandoc/pypandocstep for "readme markdown on PyPI" that's no longer needed(PyPI renders the markdown
README.mddirectly),python setup.py sdist uploadto publish — deprecated and rejected by PyPI.Updated to the real process backed by the repo's
deploy.sh:datacache/version.pyin the release PR,./deploy.shfrom clean master (lint + test +build+twine upload).Doc-only; no version bump (not a release).