Skip to content

Validate lat/lon as floats before interpolating into the geo GraphQL query #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-tonneslan wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Validate lat/lon as floats before interpolating into the geo GraphQL query #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion public/views/legislators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ def _people_from_lat_lon(lat, lon):
}
}
}"""
# lat/lon come straight off the query string and get interpolated into a
# GraphQL query string below, so make sure they actually parse as floats
# before we hand the result to schema.execute.
lat = float(lat)
lon = float(lon)
resp = schema.execute(PERSON_GEO_QUERY % (lat, lon))

nodes = [node["node"] for node in resp.data["people"]["edges"]]
Expand Down Expand Up @@ -67,7 +72,12 @@ def find_your_legislator(request):

if json and lat and lon:
# got a passed lat/lon. Let's build off it.
people = _people_from_lat_lon(lat, lon)
try:
people = _people_from_lat_lon(lat, lon)
except ValueError:
return JsonResponse(
{"error": "lat and lon must be numeric"}, status=400
)
return JsonResponse({"legislators": people})

return render(request, "public/views/find_your_legislator.html", {})
Expand Down