Python 3.13 upgrade attempt#199
Draft
jessemortenson wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.9 is past end-of-life, so I finally got around to trying to upgrade. Targeted 3.13 since it's been out for over a year. Corresponding PR will be up in openstates-scrapers momentarily. Will move to other repos that depend on os-core after success with that.
@showerst any special process you'd like around merging these in? And of course, happy for any additional testing you want to provide.
So far I've tested a handful of os-core CLI commands, as well as a handful of scrapes (via openstates-scrapers with this version of os-core installed via --editable)
I am still getting a warning out of
requeststhat I haven't solved yet:/home/jesse/.cache/pypoetry/virtualenvs/openstates-JXIw9pZG-py3.13/lib/python3.13/site-packages/requests/__init__.py:113: RequestsDependencyWarning: urllib3 (2.7.0) or chardet (7.4.3)/charset_normalizer (3.4.1) doesn't match a supported version!also looks like some lint workflow bugs to iron out