Skip to content

People lint: add ignore role warnings option#198

Merged
jessemortenson merged 4 commits into
mainfrom
people-lint-ignore-warnings-option
Jun 4, 2026
Merged

People lint: add ignore role warnings option#198
jessemortenson merged 4 commits into
mainfrom
people-lint-ignore-warnings-option

Conversation

@jessemortenson

Copy link
Copy Markdown
Contributor

Adds a --ignore-role-warnings flag to the people lint command that avoids displaying warnings about active roles. Continues to emit errors, so this is really just about reducing verbosity around the muni/executive people.

@fishdan fishdan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The new flag is threaded from the people lint CLI into Validator and only suppresses the intended municipal/executive “no active roles” warning path; role errors still remain errors.

One small follow-up I’d consider: add a direct unit test for ignore_role_warnings=True on a municipal or executive person with no active roles, so the new behavior is locked in rather than only covered through argument plumbing. Not a blocker.

I checked the PR build and it is passing.

@jessemortenson jessemortenson merged commit 447faf4 into main Jun 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants