People lint: add ignore role warnings option#198
Merged
Conversation
fishdan
approved these changes
Jun 4, 2026
fishdan
left a comment
There was a problem hiding this comment.
Looks good to me. The new flag is threaded from the people lint CLI into Validator and only suppresses the intended municipal/executive “no active roles” warning path; role errors still remain errors.
One small follow-up I’d consider: add a direct unit test for ignore_role_warnings=True on a municipal or executive person with no active roles, so the new behavior is locked in rather than only covered through argument plumbing. Not a blocker.
I checked the PR build and it is passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a --ignore-role-warnings flag to the people lint command that avoids displaying warnings about active roles. Continues to emit errors, so this is really just about reducing verbosity around the muni/executive people.