Stop using deprecated datetime.utcnow()#193
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
datetime.utcnow() is deprecated in Python 3.12. Swap the remaining call sites for datetime.now(timezone.utc), keeping the naive-UTC shape where existing consumers expect it via .replace(tzinfo=None). Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.12 deprecated
datetime.datetime.utcnow()in favour ofdatetime.datetime.now(timezone.utc). Swapped the four remaining call sites:openstates/models/common.py—is_active()does.date().isoformat()so no shape changeopenstates/scrape/tests/test_event_scrape.py,openstates/data/tests/conftest.py,openstates/importers/tests/test_base_importer.py— these compare against / feed naive consumers, so kept the naive UTC shape via.replace(tzinfo=None)Skipped
openstates/cli/update.pyandopenstates/cli/people.pyfor now since the values there land in places (GCS object keys, naive DateTimeField saves) where a tz suffix would change behaviour - happy to tackle those in a follow-up if you'd like.