Skip to content
This repository was archived by the owner on Jul 13, 2026. It is now read-only.

Set seccompProfile to RuntimeDefault on operator pods#127

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
lpiwowar:lpiwowar/seccompProfile
Jul 1, 2026
Merged

Set seccompProfile to RuntimeDefault on operator pods#127
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
lpiwowar:lpiwowar/seccompProfile

Conversation

@lpiwowar

@lpiwowar lpiwowar commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Uncomment and apply the seccompProfile field in manager.yaml and the CSV so that operator pods always run under the RuntimeDefault seccomp profile (make it explicit).

Summary by CodeRabbit

  • Bug Fixes
    • Improved the controller pod’s security settings by enabling the default seccomp profile.
    • Removed outdated commented security configuration to keep deployment settings clearer and more consistent.

Uncomment and apply the seccompProfile field in manager.yaml and the
CSV so that operator pods always run under the RuntimeDefault seccomp
profile (make it explicit).
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a6494f37-e248-49bc-95a2-392f5478df72

📥 Commits

Reviewing files that changed from the base of the PR and between c2f43df and 4cefcf5.

📒 Files selected for processing (2)
  • bundle/manifests/openstack-lightspeed-operator.clusterserviceversion.yaml
  • config/manager/manager.yaml

📝 Walkthrough

Walkthrough

Two YAML manifests are updated to activate seccompProfile.type: RuntimeDefault in the controller-manager Pod security context: config/manager/manager.yaml replaces a previously commented-out block with the live field, and the bundle ClusterServiceVersion manifest adds the same setting.

seccompProfile Activation

Layer / File(s) Summary
Enable seccompProfile in manager and bundle manifests
config/manager/manager.yaml, bundle/manifests/openstack-lightspeed-operator.clusterserviceversion.yaml
manager.yaml replaces commented-out seccompProfile with an active type: RuntimeDefault; the bundle CSV adds the matching seccompProfile entry under the controller-manager securityContext.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through YAML fields so neat,
Uncomments a profile with a twitch of feet,
RuntimeDefault now guards the pod,
Seccomp awakens, security's broad,
The warren is safer—hop, hop, complete! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: explicitly setting operator pods' seccompProfile to RuntimeDefault.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lpiwowar

Copy link
Copy Markdown
Contributor Author

/test all

@lpiwowar lpiwowar marked this pull request as ready for review June 30, 2026 11:01
@openshift-ci openshift-ci Bot requested review from Akrog and umago June 30, 2026 11:02
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umago

umago commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 1, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 33493e6 into openstack-lightspeed:main Jul 1, 2026
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants