Rework transcripts and feedback config options#18
Merged
openshift-merge-bot[bot] merged 2 commits intoJul 13, 2026
Merged
Conversation
Inverts the boolean semantics so users set true to enable a feature rather than false. - feedbackDisabled was renamed to feedbackEnabled. - transcriptsDisabled was renamed to transcriptsEnabled. Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
Collaborator
Author
|
/hold holding the PR until the team discuss this topic |
The config option transcriptsEnabled now defaults to false. Passive data collection should require the explicit approval of the user first. Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
Collaborator
Author
|
/hold cancel Team is in agreement. We should disable transcript and rename the options |
Collaborator
|
/lgtm |
lpiwowar
approved these changes
Jul 13, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar, umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 3e72e18
into
openstack-k8s-operators:main
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
Commit #1: Rename feedback and transcripts config options
Inverts the boolean semantics so users set true to enable a feature rather than false.
Commit #2: Default transcriptsEnabled to false
The config option transcriptsEnabled now defaults to false. Passive data collection should require the explicit approval of the user first.