Skip to content

Require all pods updated before reporting IsReady #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stuggi merged 1 commit into from
Jun 17, 2026
+4 −0
Merged

Require all pods updated before reporting IsReady #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/common/deployment/deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,12 @@ func GetDeploymentWithName(
// IsReady - validates when deployment is ready deployed to whats being requested
// - the requested replicas in the spec matches the ReadyReplicas of the status
// - the Status.Replicas match Status.ReadyReplicas. if a deployment update is in progress, Replicas > ReadyReplicas
// - all pods run the current spec (UpdatedReplicas == requested replicas)
// - both when the Generatation of the object matches the ObservedGeneration of the Status
func IsReady(deployment appsv1.Deployment) bool {
return deployment.Spec.Replicas != nil &&
*deployment.Spec.Replicas == deployment.Status.ReadyReplicas &&
*deployment.Spec.Replicas == deployment.Status.UpdatedReplicas &&
deployment.Status.Replicas == deployment.Status.ReadyReplicas &&
deployment.Generation == deployment.Status.ObservedGeneration
}
2 changes: 2 additions & 0 deletions modules/common/statefulset/statefulset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,11 @@ func (s *StatefulSet) Delete(

// IsReady - validates when deployment is ready deployed to whats being requested
// - the requested replicas in the spec matches the ReadyReplicas of the status
// - all pods run the current spec (UpdatedReplicas == requested replicas)
// - both when the Generatation of the object matches the ObservedGeneration of the Status
func IsReady(deployment appsv1.StatefulSet) bool {
return deployment.Spec.Replicas != nil &&
*deployment.Spec.Replicas == deployment.Status.ReadyReplicas &&
*deployment.Spec.Replicas == deployment.Status.UpdatedReplicas &&
deployment.Generation == deployment.Status.ObservedGeneration
}
Loading