Skip to content

handshake: free libctx after the SSL_CTXs to fix use-after-free #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
npajkovsky wants to merge 2 commits into from
Closed

handshake: free libctx after the SSL_CTXs to fix use-after-free #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cb2915
handshake: free libctx after the SSL_CTXs to fix use-after-free
nikolapajkovsky Jun 29, 2026
58630be
windows-latest image uses VS-2026 now
nikolapajkovsky Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,13 +411,13 @@ jobs:
working-directory: ".\\openssl"
shell: cmd
run: |
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
call "C:\Program Files\Microsoft Visual Studio\18\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
perl Configure no-makedepend ${{ matrix.release.configopts }}
- name: "Build openssl"
working-directory: ".\\openssl"
shell: cmd
run: |
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
call "C:\Program Files\Microsoft Visual Studio\18\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
nmake
- name: "Checkout perftools"
uses: "actions/checkout@v5"
Expand Down
2 changes: 1 addition & 1 deletion source/handshake.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,9 @@ static void free_ctx_pool()
return;
for (int i = 0; i < pool_size; ++i) {
if (ctx_pool[i]) {
OSSL_LIB_CTX_free(ctx_pool[i]->libctx);
SSL_CTX_free(ctx_pool[i]->sctx);
SSL_CTX_free(ctx_pool[i]->cctx);
OSSL_LIB_CTX_free(ctx_pool[i]->libctx);
OPENSSL_free(ctx_pool[i]);
}
}
Expand Down
Loading