evp_hash: add freeze option#74
Conversation
|
I think you also need to update the CMakeLists.txt to use the new flag |
jogme
left a comment
jogme
left a comment
There was a problem hiding this comment.
CI failures happening because it does not build against the feature branch.
IMO it would be better to ifdef it and check if the symbol is present with cmake, so we don't break functionality with older versions.
It's a draft and will be merged once the OpenSSL freeze is complete. I'll probably change the pr title, and consolidate all evp_* freezing options into one pr. @andrewkdinh feel free to push into the branch. |
|
@npajkovsky IMO we should merge this in, with the ifdef for OSSL_LIB_CTX_freeze. And afterwards we do the same for all the perftools. We want to use the freeze flag in perftools to test the freeze changes as they’re going in. Each EVP_* freeze addition will go in one PR at a time. |
npajkovsky
force-pushed
the
evp-hash-freeze
branch
from
e6eb5fe to
2ebd206
Compare
I'll put in TBD because I don't know how to run commands only for openssl >= 4. |
IMO the compile time check for OPENSSL_VERSION is sufficient. the cmake is complex enough. enabling the code upon the version check is sufficient once the freeze feature will land ro master. |
npajkovsky
force-pushed
the
evp-hash-freeze
branch
from
2ebd206 to
9efbcde
Compare
$ ./evp_hash -o evp_isolated -a SHA1 64 Average time per hash: 20.361076us $ ./evp_hash -o evp_isolated -a SHA1 64 -f Average time per hash: 4.336028us Fixes openssl/project#1728 Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org>
npajkovsky
force-pushed
the
evp-hash-freeze
branch
from
c991915 to
1a1fe9e
Compare
|
@andrewkdinh @Sashan @jogme, please do review once more. I hope I have addressed everything. |
| @@ -228,6 +228,7 @@ Three modes of operation: | |||
| Usage: evp_hash [-h] [-t] [-o operation] [-u update-times] [-a algorithm] thread-count | |||
There was a problem hiding this comment.
| Usage: evp_hash [-h] [-t] [-o operation] [-u update-times] [-a algorithm] thread-count | |
| Usage: evp_hash [-h] [-t] [-f] [-o operation] [-u update-times] [-a algorithm] thread-count |
$ ./evp_hash -o evp_isolated -a SHA1 64 Average time per hash: 20.361076us $ ./evp_hash -o evp_isolated -a SHA1 64 -f Average time per hash: 4.336028us Fixes openssl/project#1728 Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Norbert Pocs <norbertp@openssl.org> MergeDate: Mon Feb 16 10:57:46 2026 (Merged from #74)
|
Merged, thank you for the review. |
5 participants
$ ./evp_hash -o evp_isolated -a SHA1 64
Average time per hash: 20.361076us
$ ./evp_hash -o evp_isolated -a SHA1 64 -f
Average time per hash: 4.336028us
Fixes openssl/project#1728
Note: Build with openssl feature branch upstream/feature/method-store-freeze