evp_fetch: add -f option for selecting the exclusive fetch type#62
Closed
esyr wants to merge 6 commits into
Closed
evp_fetch: add -f option for selecting the exclusive fetch type#62esyr wants to merge 6 commits into
esyr wants to merge 6 commits into
Conversation
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
… the library Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
Sashan
requested changes
Oct 30, 2025
Sashan
left a comment
Sashan
left a comment
Contributor
There was a problem hiding this comment.
looks good, there is just one nit to get fixed. thanks.
| for (i = 0; i < ARRAY_SIZE(type_map); i++) { | ||
| if (!strcmp(fetch_type, type_map[i].name)) { | ||
| exclusive_fetch_type = type_map[i].id; | ||
| if (type_map[i] != NULL, !strcmp(fetch_type, type_map[i])) { |
Contributor
There was a problem hiding this comment.
s/NULL,/NULL &&
otherwise looks good.
Member
Author
There was a problem hiding this comment.
Ufff, good catch, thanks! Fixed.
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
…n to the envvar Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
esyr
force-pushed
the
esyr/evp_fetch-exclusive-type
branch
from
382a34f to
4ab8e0e
Compare
Sashan
approved these changes
Oct 30, 2025
Sashan
left a comment
Sashan
left a comment
Contributor
There was a problem hiding this comment.
looks good to me, thanks.
jogme
approved these changes
Oct 31, 2025
| {FETCH_MAC, OSSL_MAC_NAME_POLY1305, NULL}, | ||
| #endif | ||
| #ifndef OPENSSL_NO_ML_KEM | ||
| #if defined(OPENSSL_DO_PQ) && !defined(OPENSSL_NO_ML_KEM) |
Contributor
There was a problem hiding this comment.
nit: it would be clearer to nest these algos into OPENSSL_DO_PQ to have it only once, but fine by me
Sashan
pushed a commit
that referenced
this pull request
Nov 1, 2025
…n to the envvar Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> (Merged from #62)
Contributor
|
changes made to repo, thanks |
esyr
added a commit
to esyr/openssl-perftools
that referenced
this pull request
Nov 11, 2025
The changes address the following compiler warnings (reported by GCC 14):
ssl_poll_perf.c: In function ‘srvapp_setup_response’:
ssl_poll_perf.c:1553:33: warning: variable ‘pesb’ set but not used [-Wunused-but-set-variable]
1553 | struct poll_event_sbstream *pesb;
| ^~~~
ssl_poll_perf.c: In function ‘clntapp_write_custreamcb’:
ssl_poll_perf.c:2389:28: warning: unused variable ‘rb’ [-Wunused-variable]
2389 | struct request_buffer *rb;
| ^~
ssl_poll_perf.c: In function ‘clntapp_update_pec’:
ssl_poll_perf.c:2469:9: warning: variable ‘e’ set but not used [-Wunused-but-set-variable]
2469 | int e;
| ^
ssl_poll_perf.c: In function ‘main’:
ssl_poll_perf.c:3138:9: warning: unused variable ‘ccount’ [-Wunused-variable]
3138 | int ccount = 0;
| ^~~~~~
ssl_poll_perf.c: At top level:
ssl_poll_perf.c:1007:1: warning: ‘stream_state_str’ defined but not used [-Wunused-function]
1007 | stream_state_str(int stream_state)
| ^~~~~~~~~~~~~~~~
ssl_poll_perf.c:954:1: warning: ‘err_str_n’ defined but not used [-Wunused-function]
954 | err_str_n(unsigned long e, char *buf, size_t buf_sz)
| ^~~~~~~~~
Complements: openssl#62
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently,
evp_fetchtest has an (undocumented) environment variable that allows specifying a fetch algorithm to be fetched exclusively, instead of iterating over all the available ones in a round robin fashion. Define a command-line option for that, similarly to the way other parameters are controlled in other tests, and document it, along with the original environment variable.