Skip to content

benchmarks: Reduce code repetition#61

Closed
jogme wants to merge 1 commit into
openssl:mainfrom
jogme:refactor
Closed

benchmarks: Reduce code repetition#61
jogme wants to merge 1 commit into
openssl:mainfrom
jogme:refactor

Conversation

@jogme

@jogme jogme commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

@vavroch2010 vavroch2010 requested a review from Sashan October 29, 2025 09:02
@andrewkdinh andrewkdinh self-requested a review October 29, 2025 09:02

@andrewkdinh andrewkdinh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits

Comment thread bench-scripts/bench_run_apache.sh Outdated
Comment thread bench-scripts/bench_run_apache.sh Outdated
Resolves: openssl/project#1696

Signed-off-by: Norbert Pocs <norbertp@openssl.org>

@Sashan Sashan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Sashan pushed a commit that referenced this pull request Oct 29, 2025
Resolves: openssl/project#1696

Signed-off-by: Norbert Pocs <norbertp@openssl.org>

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
(Merged from #61)
@Sashan

Sashan commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

fixed via. 63358ea

@Sashan Sashan closed this Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce code repetition in perftool benchmarks

4 participants