Skip to content

perflib, handshake: do not use OSSL_LIB_CTX on OpenSSL < 3.0#55

Closed
esyr wants to merge 1 commit into
openssl:mainfrom
esyr:esyr/openssl-1.1.1-fix
Closed

perflib, handshake: do not use OSSL_LIB_CTX on OpenSSL < 3.0#55
esyr wants to merge 1 commit into
openssl:mainfrom
esyr:esyr/openssl-1.1.1-fix

Conversation

@esyr

@esyr esyr commented Oct 17, 2025

Copy link
Copy Markdown
Member

OSSL_LIB_CTX object and related APIs have been introduced in OpenSSL 3.0, and its usage prevents compiling perftools with OpenSSL 1.1.1. So far, it is limited to specific handshake testing modes, so just put the relevant code into conditional preprocessor sections.

Resolves: #54

@esyr esyr requested review from npajkovsky and quarckster October 17, 2025 10:29
OSSL_LIB_CTX object and related APIs have been introduced in OpenSSL
3.0, and its usage prevents compiling perftools with OpenSSL 1.1.1.
So far, it is limited to specific handshake testing modes, so just put
the relevant code into conditional preprocessor sections.

Resolves: openssl#54
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
@esyr esyr force-pushed the esyr/openssl-1.1.1-fix branch from bc33826 to ff821d7 Compare October 17, 2025 10:31

@quarckster quarckster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it works

@Sashan Sashan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Sashan pushed a commit that referenced this pull request Oct 17, 2025
OSSL_LIB_CTX object and related APIs have been introduced in OpenSSL
3.0, and its usage prevents compiling perftools with OpenSSL 1.1.1.
So far, it is limited to specific handshake testing modes, so just put
the relevant code into conditional preprocessor sections.

Resolves: #54
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>

Reviewed-by: Dmitry Misharov <dmitry@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
(Merged from #55)
@Sashan

Sashan commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

the changes are merged 578f383
thanks.

@Sashan Sashan closed this Oct 17, 2025
Sashan pushed a commit to esyr/openssl-perftools that referenced this pull request Oct 18, 2025
OSSL_LIB_CTX object and related APIs have been introduced in OpenSSL
3.0, and its usage prevents compiling perftools with OpenSSL 1.1.1.
So far, it is limited to specific handshake testing modes, so just put
the relevant code into conditional preprocessor sections.

Resolves: openssl#54
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>

Reviewed-by: Dmitry Misharov <dmitry@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
(Merged from openssl#55)
Sashan pushed a commit to jogme/perftools that referenced this pull request Oct 20, 2025
OSSL_LIB_CTX object and related APIs have been introduced in OpenSSL
3.0, and its usage prevents compiling perftools with OpenSSL 1.1.1.
So far, it is limited to specific handshake testing modes, so just put
the relevant code into conditional preprocessor sections.

Resolves: openssl#54
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>

Reviewed-by: Dmitry Misharov <dmitry@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
(Merged from openssl#55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perftools cannot be built with openssl 1.1.1

5 participants