Add support for enabling PWS with local persistence - #2
Open
ruimarinho wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a PWS is set (right now only type
WUactually has any meaning on the code), OpenSprinkler-Weather will automatically register the route/weatherstation/updateweatherstation.phpto capture the WU stream.However, it will only persist changes of the captured stream if the
WEATHER_PROVIDERis set tolocal, which in my opinion is too rigid as one may want to build a list of observations prior to switching tolocalweather provider.Therefore I suggest testing the presence of the
PWSvariable instead allowing for the capturing system to fully work without having to switch providers.I will also open this PR on the upstream repository. If it gets traction, then we can simply merge back on this repository.