Registered new FIPS jobs in Sippy (config/openshift.yaml) for CI anal…

[rbhilare]

Registered new FIPS jobs in Sippy (config/openshift.yaml) for CI analytics tracking

https://redhat.atlassian.net/browse/SREP-4718
Assisted By: Claude Code

Summary by CodeRabbit

• Tests
  • Enhanced FIPS compliance testing infrastructure by adding new test variants across multiple OpenShift deployment scenarios and versions, improving security testing coverage.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7441f343-00e2-4f7b-a929-689a9af93f5a

📥 Commits

Reviewing files that changed from the base of the PR and between aeebab0 and f310744.

📒 Files selected for processing (1)

• config/openshift.yaml

---

Walkthrough

This PR updates the OpenShift CI job configuration to enable FIPS-variant periodic e2e test jobs for ROSA (Red Hat OpenShift Service on AWS) testing. New FIPS job entries are added for classic STS and HCP variants across candidate and stable versions, including OSD GCP FIPS enablement.

Changes

FIPS periodic job enablement

Layer / File(s)	Summary
FIPS periodic job entries config/openshift.yaml	Job matrix entries are updated to add new -fips- periodic e2e lines for ROSA classic STS, ROSA HCP, and OSD GCP candidate across multiple OpenShift versions, replacing prior non-FIPS entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 17

✅ Passed checks (17 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: registering new FIPS jobs in Sippy through config/openshift.yaml updates for CI analytics tracking.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Go Error Handling	✅ Passed	PR only modifies YAML configuration files (config/openshift.yaml). The custom check for "Go Error Handling" patterns is inapplicable to configuration file changes; no Go code files were modified.
Sql Injection Prevention	✅ Passed	The PR modifies config/openshift.yaml, a YAML configuration file containing CI job definitions. No SQL code or queries present; SQL injection check is not applicable.
Excessive Css In React Should Use Styles	✅ Passed	PR modifies only config/openshift.yaml (YAML config file), not React components. The check for excessive inline CSS in React components is not applicable to configuration file changes.
Test Coverage For New Features	✅ Passed	Configuration-only change to config/openshift.yaml registering FIPS jobs. No new code functions or methods added. Matches test coverage exception for "configuration-only changes."
Single Responsibility And Clear Naming	✅ Passed	Code shows clear package purposes (sippyserver, dataloader), focused structs, and contextual use of generic names (Manager, utils) demonstrating good separation of concerns and single responsibility.
Stable And Deterministic Test Names	✅ Passed	The PR modifies config/openshift.yaml (CI configuration). The repository uses standard Go testing, not Ginkgo. No Ginkgo test definitions exist that require validation.
Test Structure And Quality	✅ Passed	PR contains only configuration file changes (config/openshift.yaml) to register FIPS jobs for CI analytics tracking; no Ginkgo test code to review per custom check requirements.
Microshift Test Compatibility	✅ Passed	PR only modifies config/openshift.yaml to register existing FIPS CI jobs in Sippy; no new Ginkgo e2e tests are added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only updates YAML config for CI job tracking in sippy (analytics tool), not Ginkgo e2e tests. Repository uses standard Go testing, no Ginkgo tests present.
Topology-Aware Scheduling Compatibility	✅ Passed	PR updates config/openshift.yaml (Sippy CI config) with FIPS job entries. No deployment manifests, operators, or controllers modified. Check does not apply to configuration-only changes.
Ote Binary Stdout Contract	✅ Passed	This PR modifies the Sippy project (a CI analytics tool), not an OTE binary. The OTE Binary Stdout Contract check is inapplicable to non-OTE repositories.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only modifies config/openshift.yaml to register FIPS jobs for CI analytics tracking; no new Ginkgo e2e test code is added, so the IPv6/disconnected network test check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbhilare
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rbhilare]

/retest

[openshift-merge-bot]

Scheduling required tests:
/test e2e

[openshift-ci]

@rbhilare: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[stbenjam]

openshift.yaml is a generated file, this will get overwritten. See here for how jobs become available to sippy via OCP releases.

For pseudoreleases, you can add them to openshift-customizations.yaml.