Skip to content

Adding ROSA Gap Analysis jobs to rosa-stage#3544

Open
ravitri wants to merge 1 commit into
openshift:mainfrom
ravitri:add-gap-rosa
Open

Adding ROSA Gap Analysis jobs to rosa-stage#3544
ravitri wants to merge 1 commit into
openshift:mainfrom
ravitri:add-gap-rosa

Conversation

@ravitri
Copy link
Copy Markdown
Member

@ravitri ravitri commented May 20, 2026

Creating this PR to add the list of *rosa-gap-analysis* jobs to rosa-stage.

cc @dustman9000 @bmeng

Reference - SREP-4310

Summary by CodeRabbit

  • Chores
    • Updated automated testing configuration to include a new job pattern for ROSA Gap Analysis validations.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 143963cd-9b4f-47de-ab72-67d2f7b603c8

📥 Commits

Reviewing files that changed from the base of the PR and between 589d0cf and eede2b1.

📒 Files selected for processing (1)
  • config/openshift-customizations.yaml

Walkthrough

This PR adds a single regex pattern to the OpenShift Sippy configuration to register ROSA Gap Analysis periodic CI jobs in the Presubmit job registry, enabling job tracking alongside existing ROSA and OCM test suites.

Changes

Configuration Update

Layer / File(s) Summary
ROSA Gap Analysis job pattern
config/openshift-customizations.yaml
A new releases["Presubmits"].regexp entry matches ^periodic-ci-openshift-online-rosa-gap-analysis-main-.* job names for ROSA Gap Analysis periodic jobs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

ready-for-human-review, ok-to-test

🚥 Pre-merge checks | ✅ 17
✅ Passed checks (17 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Adding ROSA Gap Analysis jobs to rosa-stage' clearly and accurately describes the main change: adding ROSA Gap Analysis job patterns to the rosa-stage configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed Custom check for Go error handling is not applicable; PR only modifies YAML configuration file with no Go code changes.
Sql Injection Prevention ✅ Passed This PR only modifies YAML configuration file to add a job pattern regex. No SQL queries, code construction, or database operations are introduced - SQL injection prevention rules are not applicable.
Excessive Css In React Should Use Styles ✅ Passed PR modifies only YAML config (config/openshift-customizations.yaml), no React or CSS code changed. The React inline CSS check is not applicable.
Test Coverage For New Features ✅ Passed Configuration-only YAML change adding a regex pattern for ROSA Gap Analysis jobs. No new code, functions, or logic introduced. Configuration-only changes are excepted from test coverage requirements.
Single Responsibility And Clear Naming ✅ Passed Check not applicable: PR modifies only YAML configuration file, not code packages, structs, or methods.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML configuration files adding job name regex patterns, not Ginkgo test code. No Ginkgo tests (It(), Describe(), etc.) are present or modified, making the check inapplicable.
Test Structure And Quality ✅ Passed PR modifies only config/openshift-customizations.yaml—a YAML config file adding a ROSA Gap Analysis job regex pattern. No Ginkgo test code was modified, so the test quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR only modifies YAML configuration to add ROSA Gap Analysis job patterns; no new Ginkgo e2e tests are added, so MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR updates only YAML config with a ROSA Gap Analysis job regex pattern. No new Ginkgo e2e tests are added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only YAML configuration for Prow job patterns in Sippy (a CI analysis tool), not deployment manifests, operator code, or controllers; topology-aware scheduling check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR is not applicable to OTE Binary Stdout Contract check: Sippy is a data analysis tool, not an OTE test binary, and the PR only modifies YAML configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. The change only updates config/openshift-customizations.yaml with a job pattern for monitoring ROSA gap-analysis jobs in Sippy.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from dgoodwin and stbenjam May 20, 2026 08:21
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 25, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@ravitri
Copy link
Copy Markdown
Member Author

ravitri commented May 25, 2026

/test e2e

1 similar comment
@ravitri
Copy link
Copy Markdown
Member Author

ravitri commented May 25, 2026

/test e2e

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 25, 2026

@ravitri: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bmeng
Copy link
Copy Markdown
Contributor

bmeng commented May 26, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bmeng, ravitri
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants