Skip to content

Update module github.com/go-logr/logr to v1.4.3#3057

Closed
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-go-logr-logr-1.x
Closed

Update module github.com/go-logr/logr to v1.4.3#3057
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/github.com-go-logr-logr-1.x

Conversation

@red-hat-konflux
Copy link
Copy Markdown

@red-hat-konflux red-hat-konflux Bot commented Oct 25, 2025

This PR contains the following updates:

Package Change Age Confidence
github.com/go-logr/logr v1.4.1v1.4.3 age confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

go-logr/logr (github.com/go-logr/logr)

v1.4.3

Compare Source

Minor release.

What's Changed

New Contributors

Full Changelog: go-logr/logr@v1.4.2...v1.4.3

v1.4.2

Compare Source

What's Changed

Dependencies:

Full Changelog: go-logr/logr@v1.4.1...v1.4.2


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@openshift-ci openshift-ci Bot requested review from oriAdler and pvasant October 25, 2025 00:23
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 25, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 25, 2025

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-go-logr-logr-1.x branch from fda2bc6 to c62d6c4 Compare November 12, 2025 21:02
@red-hat-konflux red-hat-konflux Bot changed the title Update module github.com/go-logr/logr to v1.4.3 Update module github.com/go-logr/logr to v1.4.3 - autoclosed Feb 10, 2026
@red-hat-konflux red-hat-konflux Bot closed this Feb 10, 2026
@red-hat-konflux red-hat-konflux Bot deleted the konflux/mintmaker/master/github.com-go-logr-logr-1.x branch February 10, 2026 05:35
@red-hat-konflux red-hat-konflux Bot changed the title Update module github.com/go-logr/logr to v1.4.3 - autoclosed Update module github.com/go-logr/logr to v1.4.3 Feb 10, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Feb 10, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-go-logr-logr-1.x branch 2 times, most recently from c62d6c4 to 10d7f25 Compare February 10, 2026 09:08
@red-hat-konflux red-hat-konflux Bot changed the title Update module github.com/go-logr/logr to v1.4.3 Update module github.com/go-logr/logr to v1.4.3 - autoclosed Feb 14, 2026
@red-hat-konflux red-hat-konflux Bot closed this Feb 14, 2026
@red-hat-konflux red-hat-konflux Bot changed the title Update module github.com/go-logr/logr to v1.4.3 - autoclosed Update module github.com/go-logr/logr to v1.4.3 Feb 14, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Feb 14, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-go-logr-logr-1.x branch 2 times, most recently from 10d7f25 to bbbeea2 Compare February 14, 2026 13:08
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-go-logr-logr-1.x branch from bbbeea2 to aec4fbb Compare March 31, 2026 18:24
@red-hat-konflux red-hat-konflux Bot changed the title Update module github.com/go-logr/logr to v1.4.3 Update module github.com/go-logr/logr to v1.4.3 - autoclosed May 11, 2026
@red-hat-konflux red-hat-konflux Bot closed this May 11, 2026
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux Bot changed the title Update module github.com/go-logr/logr to v1.4.3 - autoclosed Update module github.com/go-logr/logr to v1.4.3 May 11, 2026
@red-hat-konflux red-hat-konflux Bot reopened this May 11, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/master/github.com-go-logr-logr-1.x branch 2 times, most recently from aec4fbb to 6301074 Compare May 11, 2026 16:46
@red-hat-konflux red-hat-konflux Bot restored the konflux/mintmaker/master/github.com-go-logr-logr-1.x branch May 11, 2026 16:47
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign jerichokeyne for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: eccaa625-cd1a-4297-9afd-a26ec8fc9f88

📥 Commits

Reviewing files that changed from the base of the PR and between 1835c3f and 6301074.

⛔ Files ignored due to path filters (5)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/go-logr/logr/.golangci.yaml is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/go-logr/logr/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/go-logr/logr/funcr/funcr.go is excluded by !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (1)
  • go.mod

📝 Walkthrough

Walkthrough

This pull request updates the go.mod file, specifically updating the version of the github.com/go-logr/logr dependency from v1.4.1 to v1.4.3. This is a minor version increment that modifies a single line in the module file. No other module directives or dependencies are changed in this update.

🚥 Pre-merge checks | ✅ 9 | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete relative to the repository's template. It lacks required sections including PR Summary, Detailed Description, Related Issues/PRs, Type of Change checkbox selection, Previous/After Behavior, testing steps, and Developer Verification Checklist. Complete the required sections from the template: add a brief PR summary, select the 'build' or 'chore' change type, describe testing performed, and check applicable items in the Developer Verification Checklist.
Test Structure And Quality ⚠️ Warning Ginkgo tests lack assertion failure messages (77 vs 0 with messages), limited cleanup (37 AfterEach vs 83 BeforeEach), multiple assertions per test, and no timeout specifications. Add meaningful assertion messages, implement proper cleanup in AfterEach blocks, refactor tests for single responsibility, and add timeouts to Eventually/Consistently calls.
Microshift Test Compatibility ⚠️ Warning New Ginkgo e2e tests reference APIs unavailable on MicroShift (ClusterVersion, openshift-image-registry namespace) without required protection markers. Add [Skipped:MicroShift] labels or [apigroup:config.openshift.io] tags to test names, or guard with IsMicroShiftCluster() checks per check instructions.
✅ Passed checks (9 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: updating the github.com/go-logr/logr module from v1.4.1 to v1.4.3, which matches the raw_summary and the sole modification in go.mod.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR is a dependency version bump (logr v1.4.1→v1.4.3) affecting only go.mod. No test files were modified, so the check for "Stable and Deterministic Test Names" is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only updates a Go module dependency (github.com/go-logr/logr from v1.4.1 to v1.4.3) in go.mod. No new Ginkgo e2e tests are added, so the SNO test compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates go-logr/logr version (v1.4.1→v1.4.3) in go.mod. No deployment manifests, controllers, or scheduling constraints added. Check not applicable to dependency-only updates.
Ote Binary Stdout Contract ✅ Passed Check is not applicable. ROSA is a standard CLI tool, not an OTE extension. The go-logr v1.4.3 update contains only test fixes with no stdout impact.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added. PR only updates go.logr/logr dependency from v1.4.1 to v1.4.3 in go.mod. Check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/github.com-go-logr-logr-1.x

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant