Skip to content

[DNM] Sync Serverless CI config/serverless-operator.yaml - #81650

Closed
maschmid wants to merge 1 commit into
openshift:mainfrom
maschmid:sync-serverless-ci
Closed

[DNM] Sync Serverless CI config/serverless-operator.yaml#81650
maschmid wants to merge 1 commit into
openshift:mainfrom
maschmid:sync-serverless-ci

Conversation

@maschmid

@maschmid maschmid commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

do not merge, reeharsing change to openshift-knative/hack#994

Summary by CodeRabbit

This update synchronizes OpenShift CI configuration for the openshift-knative/serverless-operator downstream build setup by bumping promotion/image references from release-1.37.1 to release-1.37.2. In practical terms, it updates the CI-generated release config used for serverless-operator promotion so the downstream CI/infrastructure points at the newer release artifacts.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9c464db6-21cb-4a33-ac87-89c299be810a

📥 Commits

Reviewing files that changed from the base of the PR and between 0706cbe and ce44761.

📒 Files selected for processing (2)
  • ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__416.yaml
  • ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__421.yaml

Walkthrough

Two CI operator configuration YAML files for openshift-knative/serverless-operator were updated to bump the release version reference from release-1.37.1 to release-1.37.2 in their respective promotion additional_images fields.

Changes

Release version bump

Layer / File(s) Summary
Update release tags in promotion configs
ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__416.yaml, ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__421.yaml
The name/tag values for additional_images in the promotion configuration are updated from release-1.37.1 to release-1.37.2.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects a sync update to Serverless CI configuration and matches the release bump changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only bumps ci-operator promotion tags in two YAMLs; no Ginkgo test titles or test code changed.
Test Structure And Quality ✅ Passed PR only changes ci-operator YAML config; no Ginkgo test files or test logic were modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only ci-operator YAML promotion tags changed; no new or modified Ginkgo tests were added, so MicroShift compatibility isn't implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator promotion tag bumps changed; no Ginkgo e2e tests were added or modified, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI promotion tag/version bumps changed; no deployment manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed Only ci-operator YAML promotion tags changed; no binary code or stdout-writing setup was modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI promotion YAML changed; no new Ginkgo/e2e tests or networking code, so IPv6/disconnected compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The PR only bumps release/tag values in two YAML promotion configs; no weak crypto, custom crypto, or secret/token comparisons were introduced.
Container-Privileges ✅ Passed Touched ci-operator YAMLs only bump release tags; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields found.
No-Sensitive-Data-In-Logs ✅ Passed Diff only bumps release tags in CI config; no new logging or sensitive data appears in the changed lines.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2026
@openshift-ci
openshift-ci Bot requested review from aliok and creydr July 9, 2026 06:33
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@maschmid: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-knative-serverless-operator-release-1.37-416-images openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-416-kitchensink-e2e openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-416-kitchensink-upgrade openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-416-mesh-e2e openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-416-mesh-upgrade openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-416-operator-e2e openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-416-test-soak openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-416-test-upgrade openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-416-ui-e2e openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-416-upstream-e2e openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-416-upstream-e2e-kafka openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-421-images openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-421-kitchensink-e2e openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-421-mesh-e2e openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-421-mesh-upgrade openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-421-operator-e2e openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-421-test-soak openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-421-test-upgrade openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-421-ui-e2e openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-421-upstream-e2e openshift-knative/serverless-operator presubmit Ci-operator config changed
pull-ci-openshift-knative-serverless-operator-release-1.37-421-upstream-e2e-kafka openshift-knative/serverless-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@maschmid: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maschmid maschmid closed this Jul 9, 2026
@maschmid
maschmid deleted the sync-serverless-ci branch July 9, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant