-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[DNM] Sync Serverless CI config/ #81603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -24,12 +24,17 @@ images: | |||||
| - dockerfile_path: openshift/ci-operator/source-image/Dockerfile | ||||||
| from: src | ||||||
| to: knative-backstage-plugins-source-image | ||||||
| run_if_changed: ^non-existing$ | ||||||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Tighten the skip regex before it skips unrelated paths. The leading Proposed fix- skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+ skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| promotion: | ||||||
| to: | ||||||
| - additional_images: | ||||||
| backstage-plugins-src: src | ||||||
| namespace: openshift | ||||||
| tag: knative-v1.21 | ||||||
| releases: | ||||||
| latest: | ||||||
| candidate: | ||||||
| product: ocp | ||||||
| stream: nightly | ||||||
| release: | ||||||
| channel: fast | ||||||
| version: "4.22" | ||||||
| resources: | ||||||
| '*': | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -24,12 +24,17 @@ images: | |||||
| - dockerfile_path: openshift/ci-operator/source-image/Dockerfile | ||||||
| from: src | ||||||
| to: knative-backstage-plugins-source-image | ||||||
| run_if_changed: ^non-existing$ | ||||||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Tighten the skip regex before it skips unrelated paths. The leading Proposed fix- skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+ skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| promotion: | ||||||
| to: | ||||||
| - additional_images: | ||||||
| backstage-plugins-src: src | ||||||
| namespace: openshift | ||||||
| tag: knative-v1.22 | ||||||
| releases: | ||||||
| latest: | ||||||
| candidate: | ||||||
| product: ocp | ||||||
| stream: nightly | ||||||
| release: | ||||||
| channel: fast | ||||||
| version: "4.22" | ||||||
| resources: | ||||||
| '*': | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -70,35 +70,36 @@ images: | |||||
| - dockerfile_path: openshift/ci-operator/source-image/Dockerfile | ||||||
| from: src | ||||||
| to: knative-client-source-image | ||||||
| run_if_changed: ^non-existing$ | ||||||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win Move the job filter out of Line 73 is indented under Proposed fix- skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| promotion: | ||||||
| to: | ||||||
| - additional_images: | ||||||
| client-src: src | ||||||
| name: knative-v1.17 | ||||||
| namespace: openshift | ||||||
| tag: knative-v1.17 | ||||||
| releases: | ||||||
| latest: | ||||||
| candidate: | ||||||
| product: ocp | ||||||
| stream: nightly | ||||||
| release: | ||||||
| channel: fast | ||||||
| version: "4.22" | ||||||
| resources: | ||||||
| '*': | ||||||
| requests: | ||||||
| cpu: 500m | ||||||
| memory: 1Gi | ||||||
| tests: | ||||||
| - always_run: false | ||||||
| as: test-e2e | ||||||
| - as: test-e2e | ||||||
| cluster_claim: | ||||||
| architecture: amd64 | ||||||
| cloud: aws | ||||||
| owner: serverless-ci | ||||||
| product: ocp | ||||||
| timeout: 2h0m0s | ||||||
| version: "4.22" | ||||||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | ||||||
| steps: | ||||||
| allow_best_effort_post_steps: true | ||||||
| allow_skip_on_success: true | ||||||
| cluster_profile: aws-serverless | ||||||
| env: | ||||||
| BASE_DOMAIN: serverless.devcluster.openshift.com | ||||||
| SPOT_INSTANCES: "true" | ||||||
| ZONES_COUNT: "1" | ||||||
| post: | ||||||
| - as: testlog-gather | ||||||
| best_effort: true | ||||||
|
|
@@ -145,7 +146,6 @@ tests: | |||||
| cpu: 300m | ||||||
| memory: 300Mi | ||||||
| timeout: 20m0s | ||||||
| - ref: ipi-deprovision-deprovision | ||||||
| test: | ||||||
| - as: test | ||||||
| cli: latest | ||||||
|
|
@@ -167,7 +167,7 @@ tests: | |||||
| requests: | ||||||
| cpu: 100m | ||||||
| timeout: 4h0m0s | ||||||
| workflow: ipi-aws | ||||||
| workflow: generic-claim | ||||||
| zz_generated_metadata: | ||||||
| branch: release-v1.17 | ||||||
| org: openshift-knative | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -70,36 +70,35 @@ images: | |||||
| - dockerfile_path: openshift/ci-operator/source-image/Dockerfile | ||||||
| from: src | ||||||
| to: knative-client-source-image | ||||||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | ||||||
| run_if_changed: ^non-existing$ | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win Move Line 73 is nested under Proposed fix- run_if_changed: ^non-existing$
+run_if_changed: ^non-existing$📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| promotion: | ||||||
| to: | ||||||
| - additional_images: | ||||||
| client-src: src | ||||||
| name: knative-v1.17 | ||||||
| namespace: openshift | ||||||
| tag: knative-v1.17 | ||||||
| releases: | ||||||
| latest: | ||||||
| release: | ||||||
| channel: fast | ||||||
| version: "4.21" | ||||||
| candidate: | ||||||
| product: ocp | ||||||
| stream: nightly | ||||||
| version: "5.0" | ||||||
| resources: | ||||||
| '*': | ||||||
| requests: | ||||||
| cpu: 500m | ||||||
| memory: 1Gi | ||||||
| tests: | ||||||
| - as: test-e2e | ||||||
| cluster_claim: | ||||||
| architecture: amd64 | ||||||
| cloud: aws | ||||||
| owner: serverless-ci | ||||||
| product: ocp | ||||||
| timeout: 2h0m0s | ||||||
| version: "4.21" | ||||||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | ||||||
| - always_run: false | ||||||
| as: test-e2e | ||||||
| steps: | ||||||
| allow_best_effort_post_steps: true | ||||||
| allow_skip_on_success: true | ||||||
| cluster_profile: aws-serverless | ||||||
| env: | ||||||
| BASE_DOMAIN: serverless.devcluster.openshift.com | ||||||
| SPOT_INSTANCES: "true" | ||||||
| ZONES_COUNT: "1" | ||||||
| post: | ||||||
| - as: testlog-gather | ||||||
| best_effort: true | ||||||
|
|
@@ -146,6 +145,7 @@ tests: | |||||
| cpu: 300m | ||||||
| memory: 300Mi | ||||||
| timeout: 20m0s | ||||||
| - ref: ipi-deprovision-deprovision | ||||||
| test: | ||||||
| - as: test | ||||||
| cli: latest | ||||||
|
|
@@ -167,9 +167,9 @@ tests: | |||||
| requests: | ||||||
| cpu: 100m | ||||||
| timeout: 4h0m0s | ||||||
| workflow: generic-claim | ||||||
| workflow: ipi-aws | ||||||
| zz_generated_metadata: | ||||||
| branch: release-v1.17 | ||||||
| org: openshift-knative | ||||||
| repo: client | ||||||
| variant: "421" | ||||||
| variant: "50" | ||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -70,35 +70,36 @@ images: | |||||
| - dockerfile_path: openshift/ci-operator/source-image/Dockerfile | ||||||
| from: src | ||||||
| to: knative-client-source-image | ||||||
| run_if_changed: ^non-existing$ | ||||||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win Move the job filter out of Line 73 is indented under Proposed fix- skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| promotion: | ||||||
| to: | ||||||
| - additional_images: | ||||||
| client-src: src | ||||||
| name: knative-v1.21 | ||||||
| namespace: openshift | ||||||
| tag: knative-v1.21 | ||||||
| releases: | ||||||
| latest: | ||||||
| candidate: | ||||||
| product: ocp | ||||||
| stream: nightly | ||||||
| release: | ||||||
| channel: fast | ||||||
| version: "4.22" | ||||||
| resources: | ||||||
| '*': | ||||||
| requests: | ||||||
| cpu: 500m | ||||||
| memory: 1Gi | ||||||
| tests: | ||||||
| - always_run: false | ||||||
| as: test-e2e | ||||||
| - as: test-e2e | ||||||
| cluster_claim: | ||||||
| architecture: amd64 | ||||||
| cloud: aws | ||||||
| owner: serverless-ci | ||||||
| product: ocp | ||||||
| timeout: 2h0m0s | ||||||
| version: "4.22" | ||||||
| skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md | ||||||
| steps: | ||||||
| allow_best_effort_post_steps: true | ||||||
| allow_skip_on_success: true | ||||||
| cluster_profile: aws-serverless | ||||||
| env: | ||||||
| BASE_DOMAIN: serverless.devcluster.openshift.com | ||||||
| SPOT_INSTANCES: "true" | ||||||
| ZONES_COUNT: "1" | ||||||
| post: | ||||||
| - as: testlog-gather | ||||||
| best_effort: true | ||||||
|
|
@@ -145,7 +146,6 @@ tests: | |||||
| cpu: 300m | ||||||
| memory: 300Mi | ||||||
| timeout: 20m0s | ||||||
| - ref: ipi-deprovision-deprovision | ||||||
| test: | ||||||
| - as: test | ||||||
| cli: latest | ||||||
|
|
@@ -167,7 +167,7 @@ tests: | |||||
| requests: | ||||||
| cpu: 100m | ||||||
| timeout: 4h0m0s | ||||||
| workflow: ipi-aws | ||||||
| workflow: generic-claim | ||||||
| zz_generated_metadata: | ||||||
| branch: release-v1.21 | ||||||
| org: openshift-knative | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Tighten the skip regex before it skips unrelated paths.
The leading
.in.tekton,.konflux,.github, andrpms.lock.yamlis currently a wildcard, and.*\.mdis not end-anchored.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents