Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,17 @@ images:
- dockerfile_path: openshift/ci-operator/source-image/Dockerfile
from: src
to: knative-backstage-plugins-source-image
run_if_changed: ^non-existing$
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Tighten the skip regex before it skips unrelated paths.

The leading . in .tekton, .konflux, .github, and rpms.lock.yaml is currently a wildcard, and .*\.md is not end-anchored.

Proposed fix
-  skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+  skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.17__422.yaml`
at line 27, The skip_if_only_changed pattern is too broad because the leading
dot in the hidden directories is treated as a wildcard and the markdown match is
not end-anchored. Update the regex in the release config to escape the literal
dots for .tekton, .konflux, and .github, and anchor the markdown rule so it only
matches files ending in .md. Keep the existing behavior for the hack, OWNERS,
and rpms.lock.yaml paths while tightening the matching in this configuration
key.

promotion:
to:
- additional_images:
backstage-plugins-src: src
namespace: openshift
tag: knative-v1.17
releases:
latest:
candidate:
product: ocp
stream: nightly
release:
channel: fast
version: "4.22"
resources:
'*':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,13 @@ images:
- dockerfile_path: openshift/ci-operator/source-image/Dockerfile
from: src
to: knative-backstage-plugins-source-image
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
promotion:
to:
- additional_images:
backstage-plugins-src: src
namespace: openshift
tag: knative-v1.17
run_if_changed: ^non-existing$
releases:
latest:
release:
channel: fast
version: "4.21"
candidate:
product: ocp
stream: nightly
version: "5.0"
resources:
'*':
requests:
Expand All @@ -45,4 +40,4 @@ zz_generated_metadata:
branch: release-v1.17
org: openshift-knative
repo: backstage-plugins
variant: "421"
variant: "50"
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,17 @@ images:
- dockerfile_path: openshift/ci-operator/source-image/Dockerfile
from: src
to: knative-backstage-plugins-source-image
run_if_changed: ^non-existing$
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Tighten the skip regex before it skips unrelated paths.

The leading . in .tekton, .konflux, .github, and rpms.lock.yaml is currently a wildcard, and .*\.md is not end-anchored.

Proposed fix
-  skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+  skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.21__422.yaml`
at line 27, The skip_if_only_changed pattern is too broad because the leading
dots in .tekton, .konflux, and .github are acting as wildcards, and the markdown
matcher is not anchored to the end. Update the regex in the release config entry
to escape the literal dots for those path prefixes and tighten the markdown rule
so it only matches files ending in .md, keeping the rest of the skip logic in
the same pattern.

promotion:
to:
- additional_images:
backstage-plugins-src: src
namespace: openshift
tag: knative-v1.21
releases:
latest:
candidate:
product: ocp
stream: nightly
release:
channel: fast
version: "4.22"
resources:
'*':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,13 @@ images:
- dockerfile_path: openshift/ci-operator/source-image/Dockerfile
from: src
to: knative-backstage-plugins-source-image
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
promotion:
to:
- additional_images:
backstage-plugins-src: src
namespace: openshift
tag: knative-v1.21
run_if_changed: ^non-existing$
releases:
latest:
release:
channel: fast
version: "4.21"
candidate:
product: ocp
stream: nightly
version: "5.0"
resources:
'*':
requests:
Expand All @@ -45,4 +40,4 @@ zz_generated_metadata:
branch: release-v1.21
org: openshift-knative
repo: backstage-plugins
variant: "421"
variant: "50"
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,17 @@ images:
- dockerfile_path: openshift/ci-operator/source-image/Dockerfile
from: src
to: knative-backstage-plugins-source-image
run_if_changed: ^non-existing$
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Tighten the skip regex before it skips unrelated paths.

The leading . in .tekton, .konflux, .github, and rpms.lock.yaml is currently a wildcard, and .*\.md is not end-anchored.

Proposed fix
-  skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+  skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
skip_if_only_changed: ^\.tekton/.*|^\.konflux.*|^\.github/.*|^rpms\.lock\.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md$
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift-knative/backstage-plugins/openshift-knative-backstage-plugins-release-v1.22__422.yaml`
at line 27, The skip_if_only_changed pattern is too broad because the leading
dot in the .tekton, .konflux, and .github path checks is acting as a wildcard,
and the markdown matcher is not anchored. Update the regex in the release config
to escape those literal dot-prefixed directories/files and tighten the markdown
match so it only skips .md files, using the skip_if_only_changed entry as the
target to adjust.

promotion:
to:
- additional_images:
backstage-plugins-src: src
namespace: openshift
tag: knative-v1.22
releases:
latest:
candidate:
product: ocp
stream: nightly
release:
channel: fast
version: "4.22"
resources:
'*':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,13 @@ images:
- dockerfile_path: openshift/ci-operator/source-image/Dockerfile
from: src
to: knative-backstage-plugins-source-image
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
promotion:
to:
- additional_images:
backstage-plugins-src: src
namespace: openshift
tag: knative-v1.22
run_if_changed: ^non-existing$
releases:
latest:
release:
channel: fast
version: "4.21"
candidate:
product: ocp
stream: nightly
version: "5.0"
resources:
'*':
requests:
Expand All @@ -45,4 +40,4 @@ zz_generated_metadata:
branch: release-v1.22
org: openshift-knative
repo: backstage-plugins
variant: "421"
variant: "50"
Original file line number Diff line number Diff line change
Expand Up @@ -70,35 +70,36 @@ images:
- dockerfile_path: openshift/ci-operator/source-image/Dockerfile
from: src
to: knative-client-source-image
run_if_changed: ^non-existing$
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Move the job filter out of images.

Line 73 is indented under images, so the intended root-level skip_if_only_changed is parsed as images.skip_if_only_changed instead of a CI job property.

Proposed fix
-  skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.17__422.yaml`
at line 73, The root-level job filter is currently nested under images, so move
skip_if_only_changed out of the images block in the
openshift-knative-client-release-v1.17 configuration. Keep the setting at the
top level alongside the CI job fields so it is parsed as a job property rather
than images.skip_if_only_changed, and verify the images section only contains
image-related keys.

promotion:
to:
- additional_images:
client-src: src
name: knative-v1.17
namespace: openshift
tag: knative-v1.17
releases:
latest:
candidate:
product: ocp
stream: nightly
release:
channel: fast
version: "4.22"
resources:
'*':
requests:
cpu: 500m
memory: 1Gi
tests:
- always_run: false
as: test-e2e
- as: test-e2e
cluster_claim:
architecture: amd64
cloud: aws
owner: serverless-ci
product: ocp
timeout: 2h0m0s
version: "4.22"
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
steps:
allow_best_effort_post_steps: true
allow_skip_on_success: true
cluster_profile: aws-serverless
env:
BASE_DOMAIN: serverless.devcluster.openshift.com
SPOT_INSTANCES: "true"
ZONES_COUNT: "1"
post:
- as: testlog-gather
best_effort: true
Expand Down Expand Up @@ -145,7 +146,6 @@ tests:
cpu: 300m
memory: 300Mi
timeout: 20m0s
- ref: ipi-deprovision-deprovision
test:
- as: test
cli: latest
Expand All @@ -167,7 +167,7 @@ tests:
requests:
cpu: 100m
timeout: 4h0m0s
workflow: ipi-aws
workflow: generic-claim
zz_generated_metadata:
branch: release-v1.17
org: openshift-knative
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,36 +70,35 @@ images:
- dockerfile_path: openshift/ci-operator/source-image/Dockerfile
from: src
to: knative-client-source-image
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
run_if_changed: ^non-existing$

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Move run_if_changed out of images.

Line 73 is nested under images, so the gate is parsed as images.run_if_changed rather than a CI job property; with always_run: false, that can change when the presubmit is triggered.

Proposed fix
-  run_if_changed: ^non-existing$
+run_if_changed: ^non-existing$
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run_if_changed: ^non-existing$
run_if_changed: ^non-existing$
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.17__50.yaml`
at line 73, The presubmit trigger configuration is nested incorrectly under the
images block, so run_if_changed is being treated as images.run_if_changed
instead of a job-level setting. Move run_if_changed out of the images section in
the affected config so it is parsed as a CI job property alongside always_run
and the other top-level presubmit fields.

promotion:
to:
- additional_images:
client-src: src
name: knative-v1.17
namespace: openshift
tag: knative-v1.17
releases:
latest:
release:
channel: fast
version: "4.21"
candidate:
product: ocp
stream: nightly
version: "5.0"
resources:
'*':
requests:
cpu: 500m
memory: 1Gi
tests:
- as: test-e2e
cluster_claim:
architecture: amd64
cloud: aws
owner: serverless-ci
product: ocp
timeout: 2h0m0s
version: "4.21"
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
- always_run: false
as: test-e2e
steps:
allow_best_effort_post_steps: true
allow_skip_on_success: true
cluster_profile: aws-serverless
env:
BASE_DOMAIN: serverless.devcluster.openshift.com
SPOT_INSTANCES: "true"
ZONES_COUNT: "1"
post:
- as: testlog-gather
best_effort: true
Expand Down Expand Up @@ -146,6 +145,7 @@ tests:
cpu: 300m
memory: 300Mi
timeout: 20m0s
- ref: ipi-deprovision-deprovision
test:
- as: test
cli: latest
Expand All @@ -167,9 +167,9 @@ tests:
requests:
cpu: 100m
timeout: 4h0m0s
workflow: generic-claim
workflow: ipi-aws
zz_generated_metadata:
branch: release-v1.17
org: openshift-knative
repo: client
variant: "421"
variant: "50"
Original file line number Diff line number Diff line change
Expand Up @@ -70,35 +70,36 @@ images:
- dockerfile_path: openshift/ci-operator/source-image/Dockerfile
from: src
to: knative-client-source-image
run_if_changed: ^non-existing$
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Move the job filter out of images.

Line 73 is indented under images, so the intended root-level skip_if_only_changed is parsed as images.skip_if_only_changed instead of a CI job property.

Proposed fix
-  skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
+skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift-knative/client/openshift-knative-client-release-v1.21__422.yaml`
at line 73, The `skip_if_only_changed` setting is nested under `images` in the
release config, so it is being parsed as an image-level field instead of a
top-level CI job filter. Move `skip_if_only_changed` out to the root of the
config in the `openshift-knative-client-release-v1.21__422.yaml` definition so
it applies to the job itself, and keep the existing regex value unchanged.

promotion:
to:
- additional_images:
client-src: src
name: knative-v1.21
namespace: openshift
tag: knative-v1.21
releases:
latest:
candidate:
product: ocp
stream: nightly
release:
channel: fast
version: "4.22"
resources:
'*':
requests:
cpu: 500m
memory: 1Gi
tests:
- always_run: false
as: test-e2e
- as: test-e2e
cluster_claim:
architecture: amd64
cloud: aws
owner: serverless-ci
product: ocp
timeout: 2h0m0s
version: "4.22"
skip_if_only_changed: ^.tekton/.*|^.konflux.*|^.github/.*|^rpms.lock.yaml$|^hack/(lib$|[^l].*|l[^i].*|li[^b].*|lib[^/].*)|^OWNERS.*|.*\.md
steps:
allow_best_effort_post_steps: true
allow_skip_on_success: true
cluster_profile: aws-serverless
env:
BASE_DOMAIN: serverless.devcluster.openshift.com
SPOT_INSTANCES: "true"
ZONES_COUNT: "1"
post:
- as: testlog-gather
best_effort: true
Expand Down Expand Up @@ -145,7 +146,6 @@ tests:
cpu: 300m
memory: 300Mi
timeout: 20m0s
- ref: ipi-deprovision-deprovision
test:
- as: test
cli: latest
Expand All @@ -167,7 +167,7 @@ tests:
requests:
cpu: 100m
timeout: 4h0m0s
workflow: ipi-aws
workflow: generic-claim
zz_generated_metadata:
branch: release-v1.21
org: openshift-knative
Expand Down
Loading