Skip to content

Add hypershift release-4.22 to pipeline controller lgtm-config#79626

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bryan-cox:pipeline-controller-hypershift-release-4.22
May 21, 2026
Merged

Add hypershift release-4.22 to pipeline controller lgtm-config#79626
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bryan-cox:pipeline-controller-hypershift-release-4.22

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

@bryan-cox bryan-cox commented May 21, 2026

Summary

  • The pipeline controller's lgtm-config.yaml only watches main for openshift/hypershift, so e2e jobs using pipeline_skip_if_only_changed on release-4.22 never trigger
  • Multiple release-4.22 PRs have merged without any e2e test coverage

Evidence

Branch PR Go files changed e2e jobs triggered Mechanism
release-4.22 #8564 Yes 0 pipeline_skip_if_only_changed
release-4.22 #8534 Yes 0 pipeline_skip_if_only_changed
release-4.22 #8447 Yes 0 pipeline_skip_if_only_changed
release-4.21 #8531 Yes 6 skip_if_only_changed
main #8552 Yes 7 pipeline_skip_if_only_changed

The same commit (main #8552 → release-4.22 #8564 cherry-pick) gets full e2e coverage on main and zero on release-4.22.

Test plan

  • Verify pipeline controller picks up the config change after merge
  • Confirm next release-4.22 PR with Go changes triggers e2e jobs

🤖 Generated with Claude Code

Summary by CodeRabbit

This PR updates OpenShift CI configuration so the pipeline controller stops restricting its lgtm-config entry for openshift/hypershift to only the main branch. In practical terms, core-services/pipeline-controller/lgtm-config.yaml now lists the hypershift repo without a branch filter, allowing the pipeline controller to monitor release branches (including release-4.22) in addition to main.

Why this matters: the pipeline controller uses this config to determine when to run e2e jobs gated by pipeline_skip_if_only_changed. Previously, release-4.22 PRs that changed Go files did not trigger those e2e jobs because only main was watched; removing the branch filter ensures release-4.22 (and future release branches) receive equivalent automated e2e coverage.

Impact: configuration-only change to OpenShift CI (pipeline controller). After merge, the pipeline controller should pick up the change and subsequent release-4.22 PRs with Go changes will trigger the expected e2e jobs.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3022dd4b-5f83-4608-8e6f-e2979469702e

📥 Commits

Reviewing files that changed from the base of the PR and between 1a6b58b and f2404e5.

📒 Files selected for processing (1)
  • core-services/pipeline-controller/lgtm-config.yaml

Walkthrough

Adds release-4.22 to the hypershift LGTM branch list for the openshift org's main configuration in the pipeline-controller LGTM config.

Changes

LGTM Configuration Update

Layer / File(s) Summary
Add release-4.22 branch to hypershift configuration
core-services/pipeline-controller/lgtm-config.yaml
Adds release-4.22 as a new branch entry under the hypershift branches for the openshift organization's main LGTM configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

lgtm, approved

Suggested reviewers

  • pruan-rht
  • psalajova
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding hypershift release-4.22 support to the pipeline controller's lgtm-config.yaml file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies a YAML configuration file (lgtm-config.yaml) with no Ginkgo test definitions, test titles, or code introducing test names. Check is not applicable.
Test Structure And Quality ✅ Passed This PR contains no Ginkgo tests—only standard Go unit tests. The custom check for Ginkgo test quality is not applicable, so it passes by default.
Microshift Test Compatibility ✅ Passed This PR only modifies lgtm-config.yaml (a pipeline controller configuration file); it does not add any Ginkgo e2e tests, so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies lgtm-config.yaml for CI pipeline configuration. No new Ginkgo e2e tests (It, Describe, Context, When) are added, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only a pipeline controller configuration file listing repos to monitor. No deployment manifests, operator code, controllers, or scheduling constraints are affected.
Ote Binary Stdout Contract ✅ Passed PR modifies only lgtm-config.yaml (YAML configuration). No source code changes present; OTE Binary Stdout Contract check only applies to code, making it inapplicable here.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only a YAML configuration file (lgtm-config.yaml), not Ginkgo e2e tests. Check applies only when new tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from pruan-rht and psalajova May 21, 2026 16:58
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@celebdor
Copy link
Copy Markdown
Contributor

/lgtm

The pipeline controller's lgtm-config only watched the main branch
for openshift/hypershift. This meant e2e jobs using
pipeline_skip_if_only_changed on release-4.22 never triggered because
the controller didn't monitor that branch.

Multiple release-4.22 PRs merged without e2e test coverage (openshift#8564,
openshift#8534, openshift#8447) while the same commits on main got full e2e runs.

Remove the branch filter entirely so all branches are watched,
matching the pattern used by other repos in the config. This prevents
the same issue on future release branches.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@bryan-cox bryan-cox force-pushed the pipeline-controller-hypershift-release-4.22 branch from 1a6b58b to f2404e5 Compare May 21, 2026 17:09
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@celebdor
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, celebdor, csrwng, deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bryan-cox: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 9ffecd0 into openshift:main May 21, 2026
7 checks passed
@bryan-cox bryan-cox deleted the pipeline-controller-hypershift-release-4.22 branch May 21, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants