Add hypershift release-4.22 to pipeline controller lgtm-config#79626
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughAdds ChangesLGTM Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/lgtm |
The pipeline controller's lgtm-config only watched the main branch for openshift/hypershift. This meant e2e jobs using pipeline_skip_if_only_changed on release-4.22 never triggered because the controller didn't monitor that branch. Multiple release-4.22 PRs merged without e2e test coverage (openshift#8564, openshift#8534, openshift#8447) while the same commits on main got full e2e runs. Remove the branch filter entirely so all branches are watched, matching the pattern used by other repos in the config. This prevents the same issue on future release branches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1a6b58b to
f2404e5
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, celebdor, csrwng, deepsm007 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
lgtm-config.yamlonly watchesmainforopenshift/hypershift, so e2e jobs usingpipeline_skip_if_only_changedonrelease-4.22never triggerEvidence
pipeline_skip_if_only_changedpipeline_skip_if_only_changedpipeline_skip_if_only_changedskip_if_only_changedpipeline_skip_if_only_changedThe same commit (main #8552 → release-4.22 #8564 cherry-pick) gets full e2e coverage on main and zero on release-4.22.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
This PR updates OpenShift CI configuration so the pipeline controller stops restricting its lgtm-config entry for openshift/hypershift to only the main branch. In practical terms, core-services/pipeline-controller/lgtm-config.yaml now lists the hypershift repo without a branch filter, allowing the pipeline controller to monitor release branches (including release-4.22) in addition to main.
Why this matters: the pipeline controller uses this config to determine when to run e2e jobs gated by pipeline_skip_if_only_changed. Previously, release-4.22 PRs that changed Go files did not trigger those e2e jobs because only main was watched; removing the branch filter ensures release-4.22 (and future release branches) receive equivalent automated e2e coverage.
Impact: configuration-only change to OpenShift CI (pipeline controller). After merge, the pipeline controller should pick up the change and subsequent release-4.22 PRs with Go changes will trigger the expected e2e jobs.