Skip to content

NE-1324: E2E test for External DNS Operator Shared VPC#42894

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
gcs278:external-dns-shared-vpc-e2e
Sep 18, 2023
Merged

NE-1324: E2E test for External DNS Operator Shared VPC#42894
openshift-merge-robot merged 1 commit into
openshift:masterfrom
gcs278:external-dns-shared-vpc-e2e

Conversation

@gcs278

@gcs278 gcs278 commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

This introduces a new test job for the external-dns-operator repo called e2e-aws-shared-vpc-phz-operator as well as a new workflow optional-operators-ci-aws-shared-vpc-phz.

The new workflow optional-operators-ci-aws-shared-vpc-phz is a combination of the existing workflows openshift-e2e-aws-shared-vpc-phz and optional-operators-ci-aws. This new workflow installs and configures cluster that is using a Shared Route 53 Private Hosted Zone with another AWS account and then installs an optional operator (external-dns-operator in this case).

The job e2e-aws-shared-vpc-phz-operator runs the workflow optional-operators-ci-aws-shared-vpc-phz with parameters for installing the external-dns-operator. It runs the operator's E2E test suite after configuring the cluster with a shared Route 53 and the external-dns-operator.

See openshift/external-dns-operator#195 for the implementation and E2E test openshift/external-dns-operator#198 that is the motivation for this new E2E test.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 31, 2023
@openshift-ci-robot

openshift-ci-robot commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

@gcs278: This pull request references NE-1324 which is a valid jira issue.

Details

In response to this:

WIP (still learning about CI jobs)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2023
@openshift-ci

openshift-ci Bot commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@gcs278, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: error unmarshaling /var/tmp/gitrepo1899307973/ci-operator/jobs/openshift/external-dns-operator/openshift-external-dns-operator-main-presubmits.yaml: error converting YAML to JSON: yaml: line 482: did not find expected key
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@gcs278
gcs278 force-pushed the external-dns-shared-vpc-e2e branch from dd7dfeb to b9a7e19 Compare September 1, 2023 14:51
@gcs278
gcs278 marked this pull request as ready for review September 1, 2023 14:51
@openshift-ci
openshift-ci Bot requested review from Miciah and frobware September 1, 2023 14:52
@gcs278

gcs278 commented Sep 1, 2023

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@gcs278, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: either both of job.Trigger and job.RerunCommand must be set, wasnt the case for job "pull-ci-openshift-external-dns-operator-main-e2e-aws-ovn-shared-vpc-phz"
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@gcs278
gcs278 force-pushed the external-dns-shared-vpc-e2e branch 3 times, most recently from 8dd224f to f88a50d Compare September 1, 2023 16:01
@gcs278

gcs278 commented Sep 1, 2023

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator

@openshift-ci openshift-ci Bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 1, 2023
@gcs278
gcs278 force-pushed the external-dns-shared-vpc-e2e branch from f88a50d to c6af72d Compare September 1, 2023 16:10
@openshift-ci openshift-ci Bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 1, 2023
@gcs278
gcs278 force-pushed the external-dns-shared-vpc-e2e branch from c6af72d to e992ef2 Compare September 1, 2023 16:12
@gcs278

gcs278 commented Sep 1, 2023

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator

@gcs278

gcs278 commented Sep 1, 2023

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@gcs278
gcs278 force-pushed the external-dns-shared-vpc-e2e branch from e992ef2 to e314e21 Compare September 1, 2023 17:57
@openshift-ci-robot

openshift-ci-robot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

@gcs278: This pull request references NE-1324 which is a valid jira issue.

Details

In response to this:

WIP: Still experimenting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278

gcs278 commented Sep 1, 2023

Copy link
Copy Markdown
Contributor Author

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/42894/rehearse-42894-pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator/1697644313543970816 failed due a syntax error in ci-operator/step-registry/optional-operators/ci/aws/shared-vpc-phz/optional-operators-ci-aws-shared-vpc-phz-workflow.yaml which didn't install the optional External-DNS operator

Fixed.

/pj-rehearse

@gcs278

gcs278 commented Sep 1, 2023

Copy link
Copy Markdown
Contributor Author

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/42894/rehearse-42894-pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator/1697670677244416000 failed with Shared VPC setup failure. Will dive into this next week, but in the meantime, let's try again:

/pj-rehearse

@gcs278

gcs278 commented Sep 1, 2023

Copy link
Copy Markdown
Contributor Author

/test ci/rehearse/openshift/external-dns-operator/main/e2e-aws-shared-vpc-phz-operator

@openshift-ci

openshift-ci Bot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

@gcs278: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test build08-dry
  • /test check-gh-automation
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test clusterimageset-validate
  • /test config
  • /test core-valid
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hive-dry
  • /test jira-lifecycle-config
  • /test multi01-dry
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test supplemental-ci-images-mapping-files
  • /test sync-rover-groups
  • /test vsphere02-dry
  • /test yamllint

The following commands are available to trigger optional jobs:

  • /test arm01-dry
  • /test build-clusters
  • /test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-check-gh-automation
  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/test ci/rehearse/openshift/external-dns-operator/main/e2e-aws-shared-vpc-phz-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278

gcs278 commented Sep 2, 2023

Copy link
Copy Markdown
Contributor Author

Success. Just need to write the E2E test for testing new API field AssumeRole.

@gcs278

gcs278 commented Sep 5, 2023

Copy link
Copy Markdown
Contributor Author

Retesting to check for flakes:
/test ci/rehearse/openshift/external-dns-operator/main/e2e-aws-shared-vpc-phz-operator

@openshift-ci

openshift-ci Bot commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

@gcs278: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test build08-dry
  • /test check-gh-automation
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test clusterimageset-validate
  • /test config
  • /test core-valid
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hive-dry
  • /test jira-lifecycle-config
  • /test multi01-dry
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test supplemental-ci-images-mapping-files
  • /test sync-rover-groups
  • /test vsphere02-dry
  • /test yamllint

The following commands are available to trigger optional jobs:

  • /test arm01-dry
  • /test build-clusters
  • /test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-check-gh-automation
  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint
Details

In response to this:

Retesting to check for flakes:
/test ci/rehearse/openshift/external-dns-operator/main/e2e-aws-shared-vpc-phz-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2023
@gcs278

gcs278 commented Sep 15, 2023

Copy link
Copy Markdown
Contributor Author

@alebedev87 fixed rebase. Could I get another LGTM?

@alebedev87

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2023
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@gcs278
gcs278 force-pushed the external-dns-shared-vpc-e2e branch from be357c8 to 536a077 Compare September 18, 2023 17:32
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2023
This introduces a new test job for the external-dns-operator repo
called e2e-aws-shared-vpc-phz-operator as well as a new workflow
optional-operators-ci-aws-shared-vpc-phz.

This new workflow installs and configures cluster that is using a
shared Route 53 private hosted zone with another AWS account and
then installs an optional operator.

The new job runs the new workflow with parameters for installing
the external-dns-operator. It runs the operator's E2E test suite
after configuring the cluster with a shared Route 53 and the
external-dns-operator.
@gcs278
gcs278 force-pushed the external-dns-shared-vpc-e2e branch from 536a077 to fca5cc3 Compare September 18, 2023 17:39
@gcs278

gcs278 commented Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 18, 2023
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@gcs278: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator openshift/external-dns-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 18, 2023
@gcs278

gcs278 commented Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 18, 2023
@openshift-ci-robot

openshift-ci-robot commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

@gcs278: This pull request references NE-1324 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

This introduces a new test job for the external-dns-operator repo called e2e-aws-shared-vpc-phz-operator as well as a new workflow optional-operators-ci-aws-shared-vpc-phz.

The new workflow optional-operators-ci-aws-shared-vpc-phz is a combination of the existing workflows openshift-e2e-aws-shared-vpc-phz and optional-operators-ci-aws. This new workflow installs and configures cluster that is using a Shared Route 53 Private Hosted Zone with another AWS account and then installs an optional operator (external-dns-operator in this case).

The job e2e-aws-shared-vpc-phz-operator runs the workflow optional-operators-ci-aws-shared-vpc-phz with parameters for installing the external-dns-operator. It runs the operator's E2E test suite after configuring the cluster with a shared Route 53 and the external-dns-operator.

See openshift/external-dns-operator#195 for the implementation and E2E test openshift/external-dns-operator#198 that is the motivation for this new E2E test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smg247

smg247 commented Sep 18, 2023

Copy link
Copy Markdown
Member

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@alebedev87

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@openshift-ci

openshift-ci Bot commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, gcs278, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants