Skip to content

NO-JIRA: Revert "Merge pull request #404 from Cali0707/fix-base-image" - #406

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Cali0707:revert-base-image
Jul 24, 2026
Merged

NO-JIRA: Revert "Merge pull request #404 from Cali0707/fix-base-image"#406
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Cali0707:revert-base-image

Conversation

@Cali0707

@Cali0707 Cali0707 commented Jul 23, 2026

Copy link
Copy Markdown

This reverts commit 0c38d28, reversing changes made to a0a1c37.

The original change switched our base image while it was unable to pull from the registry.

The hope is to periodically retest this PR until we see our image working again, so that we can go back to the correct image

Summary by CodeRabbit

  • Chores
    • Updated the CI build environment to use the OpenShift 5.0 base image.
    • Existing runtime behavior and permissions remain unchanged.

@Cali0707
Cali0707 requested a review from manusa as a code owner July 23, 2026 13:16
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Cali0707: This pull request explicitly references no jira issue.

Details

In response to this:

This reverts commit 0c38d28, reversing changes made to a0a1c37.

The original change switched our base image while it was unable to pull from the registry.

The hope is to periodically retest this PR until we see our image working again, so that we can go back to the correct image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from dlom and grokspawn July 23, 2026 13:16
@Cali0707

Copy link
Copy Markdown
Author

/cc @2uasimojo @grokspawn

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
@openshift-ci
openshift-ci Bot requested a review from 2uasimojo July 23, 2026 13:16
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 686ae42a-5a40-4f56-a50b-985a724139e2

📥 Commits

Reviewing files that changed from the base of the PR and between 57608f5 and 58bc16a.

📒 Files selected for processing (1)
  • Dockerfile.ci

📝 Walkthrough

Walkthrough

Changes

CI base image

Layer / File(s) Summary
Update CI base image
Dockerfile.ci
The default BASE_IMAGE changes from the OpenShift 4.23 base image to the OpenShift 5.0 base image.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: manusa

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title correctly indicates a revert of the prior base-image change and matches the PR’s intent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
Dockerfile.ci

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Cali0707

Copy link
Copy Markdown
Author

/cherry-pick release-0.4

@openshift-cherrypick-robot

Copy link
Copy Markdown

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-0.4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@2uasimojo

Copy link
Copy Markdown
Member

/lgtm

I believe this project has no reason to prefer one OCP version's builder over another. The go and rhel versions are what's relevant.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2026
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown

@Cali0707: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit a2bcd8d into openshift:main Jul 24, 2026
9 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown

@Cali0707: new pull request created: #408

Details

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants