Skip to content

OCPBUGS-85408: Follow up corrections to GettingStarted guide#13

Open
Thealisyed wants to merge 1 commit into
openshift:mainfrom
Thealisyed:fix/getting-started-review-followup
Open

OCPBUGS-85408: Follow up corrections to GettingStarted guide#13
Thealisyed wants to merge 1 commit into
openshift:mainfrom
Thealisyed:fix/getting-started-review-followup

Conversation

@Thealisyed

@Thealisyed Thealisyed commented May 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Address all outstanding review comments from PR NE-1744: Updating instructions for GettingStarted #11 that were deferred to a follow-up
  • Correct version boundaries from 4.20 to 4.19 for SMCP/Istio CR transition, gateway deployment naming, grpcroutes CRD, Ready/Programmed condition, and istio-ingressgateway deployment
  • Rewrite "Behind the scenes" paragraph to describe both SMCP and Istio CRs
  • Remove redundant cluster-admin permissions sentence
  • Clarify OSSM version requirement wording
  • Fix curl response example header ordering

Address review comments from PR openshift#11 deferred to a follow-up:

- Correct version boundaries from 4.20 to 4.19
- Rewrite "Behind the scenes" paragraph for SMCP/Istio CR context
- Remove redundant cluster-admin permissions sentence
- Clarify OSSM version requirement wording
- Fix curl response example header ordering

Assisted with Claude
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Thealisyed: This pull request references Jira Issue OCPBUGS-85408, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Address all outstanding review comments from PR NE-1744: Updating instructions for GettingStarted #11 that were deferred to a follow-up
  • Correct version boundaries from 4.20 to 4.19 for SMCP/Istio CR transition, gateway deployment naming, grpcroutes CRD, Ready/Programmed condition, and istio-ingressgateway deployment
  • Rewrite "Behind the scenes" paragraph to describe both SMCP and Istio CRs
  • Remove redundant cluster-admin permissions sentence
  • Clarify OSSM version requirement wording
  • Fix curl response example header ordering

Test plan

  • All version boundaries verified on a live OCP 4.19 cluster
  • Confirmed grpcroutes.gateway.networking.k8s.io CRD exists on 4.19
  • Confirmed Programmed condition exists on 4.19 (Ready does not)
  • Confirmed Istio CR (not SMCP) is used on 4.19
  • Confirmed deployment naming includes GatewayClass suffix on 4.19
  • Confirmed only istiod is created initially (no shared istio-ingressgateway) on 4.19
  • CodeRabbit review passed with zero findings on the changed file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from candita and grzpiotrowski May 18, 2026 16:28
* **OpenShift 4.19 and beyond:** OSSM 3 uses Istio resources instead of SMCP.
```console
$ oc get istio -A
NAME NAMESPACE PROFILE REVISIONS READY IN USE ACTIVE REVISION STATUS VERSION AGE

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will no longer be valid with Grant's NO-OLM backport, which I believe was approved up to 4.19

$ oc get service -n openshift-ingress demo-gateway
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
demo-gateway LoadBalancer 172.30.175.176 domain.us-east-1.elb.amazonaws.com 15021:30608/TCP,80:31833/TCP 47s
```

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't the deployment and services both called demo-gateway-openshift-default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants