Update kubernetes packages to v0.36.1#1550
Conversation
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 similar comments
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
11e1073 to
55990c4
Compare
|
New changes are detected. LGTM label has been removed. |
256729c to
ad9c912
Compare
ad9c912 to
b85e3fa
Compare
b85e3fa to
bf00275
Compare
bf00275 to
729f1d0
Compare
84ffca5 to
d9440a8
Compare
e042c9b to
cbff51a
Compare
e80d58f to
8bed2a4
Compare
8bed2a4 to
68ac021
Compare
📝 WalkthroughWalkthroughUpdates go.mod: toolchain directive to Go 1.26.0, bumps k8s.io/api, k8s.io/apimachinery, k8s.io/client-go, and k8s.io/apiextensions-apiserver to v0.36.1; removes indirect github.com/mxk/go-flowrate; adds indirect k8s.io/streaming v0.36.1; bumps google.golang.org/protobuf pseudo-version. ChangesGo Toolchain and Kubernetes Dependency Upgrade
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
/retest |
68ac021 to
e090e16
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 11-14: The go.mod currently mixes sigs.k8s.io/controller-runtime
v0.23.3 with k8s modules at v0.36.1, which is unsupported; either upgrade
controller-runtime to a v0.24.x release that is tested against Kubernetes
v0.36.x or downgrade the k8s modules to v0.35.0 to match controller-runtime
v0.23.3. Update the go.mod entries for sigs.k8s.io/controller-runtime and/or
k8s.io/api, k8s.io/apimachinery, k8s.io/client-go,
k8s.io/apiextensions-apiserver accordingly and run go mod tidy; ensure the
chosen controller-runtime version aligns with the Kubernetes module versions per
controller-runtime VERSIONING.md.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f90c37a4-8669-46d9-8ccc-54030b3f97d1
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum,!go.sum
📒 Files selected for processing (1)
go.mod
| k8s.io/api v0.36.1 | ||
| k8s.io/apimachinery v0.36.1 | ||
| k8s.io/client-go v0.36.1 | ||
| sigs.k8s.io/controller-runtime v0.23.3 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What Kubernetes module versions (k8s.io/api, k8s.io/apimachinery, k8s.io/client-go) are officially supported by sigs.k8s.io/controller-runtime v0.23.3? Please provide upstream documentation or release notes links.
💡 Result:
The sigs.k8s.io/controller-runtime v0.23.3 module depends on and is specifically tested with Kubernetes module version v0.35.0 [1][2]. Specifically, the following Kubernetes modules are required at version v0.35.0 for controller-runtime v0.23.3 [2]: - k8s.io/api - k8s.io/apimachinery - k8s.io/client-go Upstream documentation, including the project's go.mod file and versioning guidelines, confirms that each minor version of controller-runtime is created to align with a corresponding minor version of these Kubernetes dependencies [3][4]. While controller-runtime may happen to work with other versions, such compatibility is neither supported nor tested by the project [3]. References: - controller-runtime v0.23.3 go.mod: https://github.com/kubernetes-sigs/controller-runtime/blob/v0.23.3/go.mod [2] - controller-runtime Releases: https://github.com/kubernetes-sigs/controller-runtime/releases [5] - Versioning and Branching Policy: https://github.com/kubernetes-sigs/controller-runtime/blob/v0.23.3/VERSIONING.md [4]
Citations:
- 1: https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.23.3
- 2: https://github.com/kubernetes-sigs/controller-runtime/blob/v0.23.3/go.mod
- 3: https://github.com/kubernetes-sigs/controller-runtime/tree/v0.23.3
- 4: https://github.com/kubernetes-sigs/controller-runtime/blob/v0.23.3/VERSIONING.md
- 5: https://github.com/kubernetes-sigs/controller-runtime/releases
Fix unsupported controller-runtime ↔ Kubernetes version skew in go.mod
sigs.k8s.io/controller-runtime v0.23.3 is upstream-tested against Kubernetes module dependencies at v0.35.0 (k8s.io/api, k8s.io/apimachinery, k8s.io/client-go). This PR bumps those Kubernetes modules to v0.36.1 (and also k8s.io/apiextensions-apiserver to v0.36.1) while leaving controller-runtime at v0.23.3, which is not an officially supported combination and can introduce subtle runtime/type skew. Align by either bumping controller-runtime to the release matching k8s v0.36.x or keeping the Kubernetes modules at v0.35.0.
Refs: controller-runtime v0.23.3 go.mod + versioning policy (https://github.com/kubernetes-sigs/controller-runtime/blob/v0.23.3/go.mod, https://github.com/kubernetes-sigs/controller-runtime/blob/v0.23.3/VERSIONING.md)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` around lines 11 - 14, The go.mod currently mixes
sigs.k8s.io/controller-runtime v0.23.3 with k8s modules at v0.36.1, which is
unsupported; either upgrade controller-runtime to a v0.24.x release that is
tested against Kubernetes v0.36.x or downgrade the k8s modules to v0.35.0 to
match controller-runtime v0.23.3. Update the go.mod entries for
sigs.k8s.io/controller-runtime and/or k8s.io/api, k8s.io/apimachinery,
k8s.io/client-go, k8s.io/apiextensions-apiserver accordingly and run go mod
tidy; ensure the chosen controller-runtime version aligns with the Kubernetes
module versions per controller-runtime VERSIONING.md.
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
e090e16 to
a52235d
Compare
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v0.35.4→v0.36.1v0.35.4→v0.36.1v0.35.4→v0.36.1v0.35.4→v0.36.1Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
kubernetes/api (k8s.io/api)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
kubernetes/apiextensions-apiserver (k8s.io/apiextensions-apiserver)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
kubernetes/apimachinery (k8s.io/apimachinery)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
kubernetes/client-go (k8s.io/client-go)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.