NO-ISSUE: Limit liveness probe to loopback interface to avoid short write errors

[mkowalski]

Manual backport of upstream nmstate#1486 (openshift/kubernetes-nmstate commit 1f02e25) to release-4.22.

The handler liveness probe runs nmstatectl show which outputs the full network state (~83KB). Kubernetes exec probes have a 10KB output limit, causing "short write" errors in kubelet logs. Restrict the probe to query only the loopback interface (nmstatectl show lo).

Clean cherry-pick, no conflicts. Verified locally: go vet on touched packages and probe-focused unit tests in controllers/operator pass on this branch.

Fixes: https://issues.redhat.com/browse/OCPBUGS-98474

Assisted-By: Claude Fable 5

[openshift-ci-robot]

@mkowalski: This pull request references Jira Issue OCPBUGS-98474, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-98474 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual backport of upstream nmstate#1486 (openshift/kubernetes-nmstate commit 1f02e25) to release-4.22.

The handler liveness probe runs nmstatectl show which outputs the full network state (~83KB). Kubernetes exec probes have a 10KB output limit, causing "short write" errors in kubelet logs. Restrict the probe to query only the loopback interface (nmstatectl show lo).

Clean cherry-pick, no conflicts. Verified locally: go vet on touched packages and probe-focused unit tests in controllers/operator pass on this branch.

Fixes: https://issues.redhat.com/browse/OCPBUGS-98474

Assisted-By: Claude Fable 5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 826029a2-de7d-436b-902a-a64f4880c093

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mkowalski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@mkowalski: This pull request explicitly references no jira issue.

Details

In response to this:

Manual backport of upstream nmstate#1486 (openshift/kubernetes-nmstate commit 1f02e25) to release-4.22.

The handler liveness probe runs nmstatectl show which outputs the full network state (~83KB). Kubernetes exec probes have a 10KB output limit, causing "short write" errors in kubelet logs. Restrict the probe to query only the loopback interface (nmstatectl show lo).

Clean cherry-pick, no conflicts. Verified locally: go vet on touched packages and probe-focused unit tests in controllers/operator pass on this branch.

Fixes: https://issues.redhat.com/browse/OCPBUGS-98474

Assisted-By: Claude Fable 5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	18516e2	link	true	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.