Skip to content

OCPBUGS-93805: update HyperShift deployment manifest#1313

Open
opokornyy wants to merge 1 commit into
openshift:masterfrom
opokornyy:OCPBUGS-93805-fix-runtime-extractor-hypershift
Open

OCPBUGS-93805: update HyperShift deployment manifest#1313
opokornyy wants to merge 1 commit into
openshift:masterfrom
opokornyy:OCPBUGS-93805-fix-runtime-extractor-hypershift

Conversation

@opokornyy

@opokornyy opokornyy commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Add missing RELATED_IMAGE environment variables to the HyperShift deployment manifest to provide correct images for the runtime extractor DaemonSet.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • None

Unit Tests

  • None

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Summary by CodeRabbit

  • Bug Fixes
    • Updated deployment defaults to include additional container image settings, helping ensure the service starts with the expected components available.

Add missing RELATED_IMAGE environment variables
to the HyperShift deployment manifest to provide
correct images for the runtime extractor
DaemonSet.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@opokornyy: This pull request references Jira Issue OCPBUGS-93805, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add missing RELATED_IMAGE environment variables to the HyperShift deployment manifest to provide correct images for the runtime extractor DaemonSet.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • None

Unit Tests

  • None

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f81da7b2-20cb-401d-ac0e-f2e9f1d7c40c

📥 Commits

Reviewing files that changed from the base of the PR and between 1eb28cd and b0ec950.

📒 Files selected for processing (1)
  • manifests/06-deployment-ibm-cloud-managed.yaml

📝 Walkthrough

Walkthrough

Three RELATED_IMAGE_* environment variables (RELATED_IMAGE_INSIGHTS_RUNTIME_EXTRACTOR, RELATED_IMAGE_INSIGHTS_RUNTIME_EXPORTER, RELATED_IMAGE_KUBE_RBAC_PROXY) are added to the insights-operator container spec in manifests/06-deployment-ibm-cloud-managed.yaml, each pointing to a quay.io/openshift/...:latest default image.

IBM Cloud Managed Deployment Manifest

Layer / File(s) Summary
Add RELATED_IMAGE env vars
manifests/06-deployment-ibm-cloud-managed.yaml
Adds three RELATED_IMAGE_* environment variables to the insights-operator container spec with quay.io/openshift/...:latest default values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the HyperShift deployment manifest.
Description check ✅ Passed The description follows the template and covers the required sections, with only minor placeholders left as acceptable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only updates a deployment manifest; no Ginkgo test files or test titles were added or changed, so nothing violates the naming rule.
Test Structure And Quality ✅ Passed Only manifests/06-deployment-ibm-cloud-managed.yaml changed; no Ginkgo test code was touched, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo tests were introduced; the PR only updates a deployment manifest with RELATED_IMAGE env vars.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR diff vs origin/master only changes manifests/06-deployment-ibm-cloud-managed.yaml; no new test files or Ginkgo markers were added, so SNO compatibility is unaffected.
Topology-Aware Scheduling Compatibility ✅ Passed The manifest change only adds RELATED_IMAGE env vars; it introduces no new topology-sensitive scheduling constraints or node selectors.
Ote Binary Stdout Contract ✅ Passed PR only updates a deployment manifest; no process-level code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR changes only a deployment manifest; no new Ginkgo e2e tests were added, so the IPv4/disconnected-network check is not applicable.
No-Weak-Crypto ✅ Passed The PR only adds RELATED_IMAGE env vars in a YAML manifest; no MD5/SHA1/DES/RC4/3DES/Blowfish, ECB, custom crypto, or secret comparisons are present.
Container-Privileges ✅ Passed The changed deployment manifest only adds RELATED_IMAGE env vars; its securityContext still has allowPrivilegeEscalation:false and runAsNonRoot:true, with no privileged/host flags.
No-Sensitive-Data-In-Logs ✅ Passed The only change adds RELATED_IMAGE env vars in a deployment manifest; no log statements or sensitive values are introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from katushiik11 and ncaak June 30, 2026 07:51
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2026
@TwoDCube

TwoDCube commented Jul 1, 2026

Copy link
Copy Markdown
Member

Seems like the RELATED_IMAGE is there and correctly substituted in the hypershift payload now

@Cluster Bot > build 5.0,openshift/insights-operator#1313

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/2071993002649194496

oc adm release extract registry.build10.ci.openshift.org/ci-ln-clflr9b/release --to=1313
$ cat 1313/0000_50_insights-operator_06-deployment-ibm-cloud-managed.yaml | yq '.spec.template.spec.containers[0].env'
- name: POD_NAME
  valueFrom:
    fieldRef:
      fieldPath: metadata.name
- name: POD_NAMESPACE
  valueFrom:
    fieldRef:
      fieldPath: metadata.namespace
- name: RELEASE_VERSION
  value: 5.0.0-0-2026-06-30-163636-test-ci-ln-clflr9b-latest
- name: RELATED_IMAGE_INSIGHTS_RUNTIME_EXTRACTOR
  value: registry.build10.ci.openshift.org/ci-ln-clflr9b/stable@sha256:feeb2bf2046ba0612d40c5e6eb87ced29b1d158883b5bef7ecf473ec7bd12cc6
- name: RELATED_IMAGE_INSIGHTS_RUNTIME_EXPORTER
  value: registry.build10.ci.openshift.org/ci-ln-clflr9b/stable@sha256:08d0b60d03c268dd94cc5774a1a1422e879a4f276f7cdfc635767a52d7daf02f
- name: RELATED_IMAGE_KUBE_RBAC_PROXY
  value: registry.build10.ci.openshift.org/ci-ln-clflr9b/stable@sha256:65f883d6e3e38a8e060ec79fca150b01d5632cce397f28b588bdd063ff20d2f1

/lgtm

@opokornyy

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

@opokornyy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/insights-operator-e2e-tests b0ec950 link true /test insights-operator-e2e-tests
ci/prow/insights-operator-serial-tests b0ec950 link true /test insights-operator-serial-tests
ci/prow/e2e b0ec950 link true /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants