[release-4.22] OCPBUGS-88026: fall back to kube-system/global-pull-secret for Insights token by openshift-cherrypick-robot · Pull Request #1305 · openshift/insights-operator

openshift-cherrypick-robot · 2026-06-10T12:47:45Z

This is an automated cherry-pick of #1302

/assign opokornyy

On ARO HCP clusters, openshift-config/pull-secret only contains the ACR registry credential — no cloud.openshift.com token. Customers add their Red Hat pull secret (including cloud.openshift.com) day-2 via the additional-pull-secret method, which HCCO merges into kube-system/global-pull-secret. This change makes updateToken() check kube-system/global-pull-secret as a fallback when openshift-config/pull-secret has no cloud.openshift.com token, enabling Insights reporting on HCP clusters without requiring platform-level changes. Changes: - Generalize fetchSecret() to accept a namespace parameter - Add fallback lookup to kube-system/global-pull-secret in updateToken() - Add read-only RBAC (Role+RoleBinding) for global-pull-secret in kube-system - Include namespace in fetchSecret log/error messages for debuggability - Add tests for fallback and primary-wins-over-fallback precedence Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Addresses review feedback to replace hardcoded string literals with named constants for better readability and maintainability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-06-10T12:47:54Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 42db0e50-4f4b-475a-8137-101cf3e14735

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

opokornyy · 2026-06-10T12:48:47Z

/cc @judexzhu

openshift-ci-robot · 2026-06-10T12:48:56Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-87889 has been cloned as Jira Issue OCPBUGS-88026. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-88026: fall back to kube-system/global-pull-secret for Insights token

Details

In response to this:

This is an automated cherry-pick of #1302

/assign opokornyy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-06-10T12:49:08Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-88026, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1302

/assign opokornyy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

opokornyy · 2026-06-11T07:02:32Z

/retest

judexzhu · 2026-06-22T17:53:34Z

/lgtm

judexzhu · 2026-06-22T17:53:49Z

/retest-required

opokornyy · 2026-06-24T06:57:58Z

/override ci/prow/insights-operator-e2e-tests

This is a known issue of the python kubernetes client

opokornyy · 2026-06-24T06:58:17Z

/jira refresh

openshift-ci · 2026-06-24T06:58:19Z

@opokornyy: Overrode contexts on behalf of opokornyy: ci/prow/insights-operator-e2e-tests

Details

In response to this:

/override ci/prow/insights-operator-e2e-tests

This is a known issue of the python kubernetes client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-06-24T06:58:22Z

@opokornyy: This pull request references Jira Issue OCPBUGS-88026, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-06-24T06:58:22Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

opokornyy · 2026-06-24T06:58:54Z

/jira refresh

openshift-ci-robot · 2026-06-24T06:59:00Z

@opokornyy: This pull request references Jira Issue OCPBUGS-88026, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-87889 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-87889 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

opokornyy · 2026-06-24T06:59:29Z

/approve

opokornyy · 2026-06-24T06:59:32Z

/lgtm

openshift-ci · 2026-06-24T06:59:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [opokornyy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

opokornyy · 2026-06-24T07:00:17Z

/verify later @opokornyy

opokornyy · 2026-06-24T07:00:28Z

/label backport-risk-assessed

opokornyy · 2026-06-24T07:02:35Z

/verified later @opokornyy

openshift-ci-robot · 2026-06-24T07:02:48Z

@opokornyy: This PR has been marked to be verified later by @opokornyy.

Details

In response to this:

/verified later @opokornyy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-06-24T07:07:54Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-88026: All pull requests linked via external trackers have merged:

openshift/insights-operator#1305

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-88026 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1302

/assign opokornyy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-06-26T02:56:48Z

Fix included in release 4.22.0-0.nightly-2026-06-25-210812

judexzhu and others added 2 commits June 10, 2026 12:47

refactor: extract namespace and secret names into constants

876ad84

Addresses review feedback to replace hardcoded string literals with named constants for better readability and maintainability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

openshift-cherrypick-robot assigned opokornyy Jun 10, 2026

openshift-cherrypick-robot mentioned this pull request Jun 10, 2026

OCPBUGS-87889: fall back to kube-system/global-pull-secret for Insights token #1302

Merged

5 tasks

openshift-ci Bot requested review from katushiik11 and ncaak June 10, 2026 12:48

openshift-ci Bot requested a review from judexzhu June 10, 2026 12:48

openshift-ci Bot changed the title ~~[release-4.22] OCPBUGS-87889: fall back to kube-system/global-pull-secret for Insights token~~ [release-4.22] OCPBUGS-88026: fall back to kube-system/global-pull-secret for Insights token Jun 10, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 10, 2026

openshift-ci Bot assigned judexzhu Jun 22, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2026

judexzhu removed their assignment Jun 22, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 24, 2026

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 24, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 24, 2026

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Jun 24, 2026

openshift-merge-bot Bot merged commit 0168ccc into openshift:release-4.22 Jun 24, 2026
12 checks passed

Uh oh!

Conversation

openshift-cherrypick-robot commented Jun 10, 2026

Uh oh!

coderabbitai Bot commented Jun 10, 2026

Review skipped

Uh oh!

opokornyy commented Jun 10, 2026

Uh oh!

openshift-ci-robot commented Jun 10, 2026

Uh oh!

openshift-ci-robot commented Jun 10, 2026

Uh oh!

opokornyy commented Jun 11, 2026

Uh oh!

judexzhu commented Jun 22, 2026

Uh oh!

judexzhu commented Jun 22, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

openshift-ci-robot commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

openshift-ci-robot commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

opokornyy commented Jun 24, 2026

Uh oh!

openshift-ci-robot commented Jun 24, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 24, 2026

Uh oh!

openshift-merge-robot commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants