Skip to content

NO-JIRA: test ARC runner infrastructure#8572

Draft
bryan-cox wants to merge 1 commit into
openshift:mainfrom
bryan-cox:test-arc-runners
Draft

NO-JIRA: test ARC runner infrastructure#8572
bryan-cox wants to merge 1 commit into
openshift:mainfrom
bryan-cox:test-arc-runners

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

@bryan-cox bryan-cox commented May 21, 2026

Trivial whitespace change to verify ARC runners work after SCC fix. Will close immediately.

Summary by CodeRabbit

  • Documentation
    • Minor formatting update to internal documentation.

Add trivial whitespace change to verify self-hosted runners are
processing jobs after SCC fix.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: This pull request explicitly references no jira issue.

Details

In response to this:

Trivial whitespace change to verify ARC runners work after SCC fix. Will close immediately.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a2e419d5-146e-47c0-b4cf-7bcefb4ca02b

📥 Commits

Reviewing files that changed from the base of the PR and between b39a15b and 5a10ac3.

📒 Files selected for processing (1)
  • hack/github-actions-runner/README.md

📝 Walkthrough

Walkthrough

This pull request adds a single line to hack/github-actions-runner/README.md at line 6 as a minor formatting or spacing adjustment. No functional content or documentation substance was altered, and no public entities were modified.

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Microshift Test Compatibility ⚠️ Warning PR adds Ginkgo tests that reference MicroShift-unavailable APIs (ImageRegistry operator, ClusterOperator) without protection tags. Add [apigroup:imageregistry.operator.openshift.io] and [apigroup:config.openshift.io] tags to test names in test/e2e/v2/tests/hosted_cluster_image_registry_test.go, or add [Skipped:MicroShift] if intentionally unsupported.
Single Node Openshift (Sno) Test Compatibility ⚠️ Warning Multiple new e2e Ginkgo tests added (autoscaling_test.go, karpenter_test.go, nodepool_rolling_upgrade_test.go, etc.) make multi-node/HA assumptions without SNO compatibility protections. Add [Skipped:SingleReplicaTopology] labels to tests assuming multiple nodes, or guard with exutil.IsSingleNode() checks. Tests like autoscaling, rolling-upgrade, and karpenter tests require multiple nodes.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the PR's purpose: testing ARC runner infrastructure with a trivial whitespace change, which aligns with the stated objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo tests. All tests use standard Go testing package with Test* functions, not Ginkgo framework. No It(), Describe(), Context(), or When() test blocks found.
Test Structure And Quality ✅ Passed PR contains only a whitespace change to hack/github-actions-runner/README.md with no Ginkgo test code, so the test structure and quality check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only hack/github-actions-runner/README.md (whitespace/formatting), not deployment manifests, operator code, or controllers. Check is not applicable to documentation-only changes.
Ote Binary Stdout Contract ✅ Passed PR's primary change is hack/github-actions-runner/README.md, a documentation file. OTE Binary Stdout Contract applies only to executable code's process-level functions, not documentation.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies hack/github-actions-runner/README.md with whitespace. No new Ginkgo e2e tests were added, so IPv6/disconnected network check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added do-not-merge/needs-area do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 21, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the area/ci-tooling Indicates the PR includes changes for CI or tooling label May 21, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels May 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.41%. Comparing base (b39a15b) to head (5a10ac3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8572   +/-   ##
=======================================
  Coverage   40.41%   40.41%           
=======================================
  Files         755      755           
  Lines       93235    93235           
=======================================
  Hits        37679    37679           
  Misses      52854    52854           
  Partials     2702     2702           
Flag Coverage Δ
cmd-support 34.44% <ø> (ø)
cpo-hostedcontrolplane 41.76% <ø> (ø)
cpo-other 40.31% <ø> (ø)
hypershift-operator 50.72% <ø> (ø)
other 31.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hypershift-jira-solve-ci
Copy link
Copy Markdown

Test Failure Analysis Complete

Job Information

  • Prow Job: gitlint / Gitlint (GitHub Actions workflow, not a Prow CI job)
  • Build ID: 26248510456 (workflow run) / 77253129981 (job)
  • PR: #8572NO-JIRA: test ARC runner infrastructure
  • Runner: arc-runner-set-2jgbn-runner-mh4mt (ARC self-hosted runner)
  • Duration: ~24 seconds (19:33:04 → 19:33:28 UTC)

Test Failure Analysis

Error

1: CT1 Title does not start with one of fix, feat, chore, docs, style, refactor, perf, test, revert, ci, build: "NO-JIRA: test ARC runner infrastructure"
make: *** [Makefile:599: run-gitlint] Error 1

Summary

The gitlint check failed because the commit title NO-JIRA: test ARC runner infrastructure does not follow the Conventional Commits format required by the repository's .gitlint configuration. The title must begin with one of the allowed type prefixes (fix, feat, chore, docs, style, refactor, perf, test, revert, ci, build) followed by a colon, but it begins with NO-JIRA: instead.

Root Cause

The repository enforces Conventional Commits via gitlint's built-in contrib-title-conventional-commits rule (configured in .gitlint at the repo root). This rule requires commit titles to match the pattern <type>[optional scope]: <description>, where <type> must be one of: fix, feat, chore, docs, style, refactor, perf, test, revert, ci, build.

The commit message on this PR is:

NO-JIRA: test ARC runner infrastructure

The prefix NO-JIRA: is not a recognized conventional commit type. The CT1 error code is gitlint's "Conventional commit Title" rule violation, confirming the title parsing failed at the very first token.

This is an intentional test PR ("Add trivial whitespace change to verify self-hosted runners are processing jobs after SCC fix") where the commit message was written to match the older Jira-prefix convention rather than the Conventional Commits standard the repo now enforces.

Recommendations
  1. Amend the commit message to use a valid Conventional Commits prefix. For this infrastructure-test PR, a suitable rewrite would be:

    ci: test ARC runner infrastructure
    

    or:

    chore: test ARC runner infrastructure
    
  2. If the PR is purely for infrastructure validation and will not be merged, the failure can be ignored — the gitlint check passing is not required for the ARC runner infrastructure to be considered validated. The fact that the job ran and produced the expected linting output confirms the self-hosted ARC runners are operational.

Evidence
Evidence Detail
Error rule CT1 — gitlint built-in contrib-title-conventional-commits rule
Commit title NO-JIRA: test ARC runner infrastructure
Allowed prefixes fix, feat, chore, docs, style, refactor, perf, test, revert, ci, build (from .gitlint)
Gitlint version 0.19.1
Config file .gitlint at repo root, contrib=contrib-title-conventional-commits
Makefile target run-gitlint (line 599) — runs gitlint --commits $(PULL_BASE_SHA)..$(PULL_PULL_SHA)
Commit range b39a15bca56104accc93c0a54152f01e1dc6c053..5a10ac3112c1b6c1623a41257895db0db0e41202
Runner ARC self-hosted runner arc-runner-set-2jgbn-runner-mh4mt (runner v2.333.0) — runner itself is functional
Exit code 2 (make propagated gitlint's non-zero exit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants