OCPBUGS-79591: Bump Golang to v1.25.8 and golangci-lint to v2.10.1

[grzpiotrowski]

• Bump Go version to v1.25.8
• Bump golangci-lint to v2.10.1 as a compatible version with Golang 1.25. Migrate .golangci.yaml to version 2.
• Resolve issues highlighted by new version of golangci-lint:

pkg/operator/controller/externaldns/deployment_test.go:4065:39  staticcheck  QF1008: could remove embedded field "VolumeSource" from selector
pkg/operator/controller/externaldns/deployment_test.go:4073:39  staticcheck  QF1008: could remove embedded field "VolumeSource" from selector
pkg/operator/controller/names.go:121:42                         staticcheck  QF1010: could convert argument to string
test/e2e/azure.go:124:19                                        staticcheck  QF1008: could remove embedded field "ZoneProperties" from selector
test/e2e/util.go:160:22                                         staticcheck  QF1008: could remove embedded field "ExternalDNSSourceUnion" from selector
test/e2e/util.go:186:22                                         staticcheck  QF1008: could remove embedded field "ExternalDNSSourceUnion" from selector

[openshift-ci-robot]

@grzpiotrowski: This pull request references Jira Issue OCPBUGS-79591, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

• Bump Go version to v1.25.8
• Bump golangci-lint to v2.10.1 as a compatible version with Golang 1.25. Migrate .golangci.yaml to version 2.
• Resolve issues highlighted by new version of golangci-lint:

pkg/operator/controller/externaldns/deployment_test.go:4065:39  staticcheck  QF1008: could remove embedded field "VolumeSource" from selector
pkg/operator/controller/externaldns/deployment_test.go:4073:39  staticcheck  QF1008: could remove embedded field "VolumeSource" from selector
pkg/operator/controller/names.go:121:42                         staticcheck  QF1010: could convert argument to string
test/e2e/azure.go:124:19                                        staticcheck  QF1008: could remove embedded field "ZoneProperties" from selector
test/e2e/util.go:160:22                                         staticcheck  QF1008: could remove embedded field "ExternalDNSSourceUnion" from selector
test/e2e/util.go:186:22                                         staticcheck  QF1008: could remove embedded field "ExternalDNSSourceUnion" from selector

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request upgrades the project's Go toolchain from version 1.24 to 1.25. Changes include updating the Go version directive in go.mod, bumping the Go toolset image versions in multiple Dockerfiles, and updating the CI operator configuration to use the newer Go 1.25 release image. Additionally, the .golangci.yaml configuration is restructured for version 2 with modified linter rules and output settings, the golangci-lint tool is upgraded from version 1.64.8 to 2.10.1, and several code references are adjusted to reflect API field restructuring in volume sources and ExternalDNS configuration. Test linter suppressions and renovate configuration rules are also updated to align with the Go 1.25 requirement.

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main changes: bumping Golang to v1.25.8 and golangci-lint to v2.10.1, which directly match the primary changes in the changeset.
Description check	✅ Passed	The description is well-related to the changeset, detailing the Go and golangci-lint version bumps, configuration migration, and the specific staticcheck issues resolved.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR does not modify any Ginkgo test definitions. Modified files use standard Go testing or are utility modules, while existing Ginkgo tests have stable, deterministic names.
Test Structure And Quality	✅ Passed	Modified files contain standard Go tests and production code, not Ginkgo test code with Describe/It blocks.
Microshift Test Compatibility	✅ Passed	This pull request does not add any new Ginkgo e2e tests. All changes are modifications to existing code to fix staticcheck issues. The check is not applicable and passes by default.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This pull request does not add any new Ginkgo e2e tests. The modified test files use the standard Go testing framework, not Ginkgo test definitions. Changes are solely modifications to existing helper functions and test mutations to address staticcheck linter findings from the upgraded golangci-lint v2.10.1. Since no new Ginkgo e2e tests are being introduced, the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only updates Go/toolchain versions and test code; no deployment manifests, scheduling constraints, affinity rules, or topology-specific logic added.
Ote Binary Stdout Contract	✅ Passed	PR changes are version bumps and build config updates with no new stdout writes introduced at process level.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. The added test files use standard Go testing.T framework, not Ginkgo-style tests, so the check is not applicable and passes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

Containerfile.external-dns-operator (1)

12-12: Consider a pinned digest or build-id suffix for reproducibility.

The previous tag (1.24.6-1763548439) included a build-id suffix, while the new 1.25.8 is just the semver tag, meaning the underlying image contents can change over time. For Konflux-built certified images, pinning to a specific build-id suffix (e.g. 1.25.8-<build-id>) or an @sha256: digest is preferable for reproducibility. Renovate should re-pin this on the next update via the existing rule in renovate.json, so this is just a minor observation.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Containerfile.external-dns-operator` at line 12, Replace the floating base
image tag in the FROM instruction
("registry.access.redhat.com/ubi9/go-toolset:1.25.8") with an immutable
reference by pinning either a build-id suffix (e.g. append "-<build-id>" to the
tag) or an `@sha256`: digest; update the FROM instruction accordingly so the
builder stage uses a reproducible image and let Renovate re-pin on its next run
per the existing renovate.json rule.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Containerfile.external-dns-operator`:
- Line 12: Replace the floating base image tag in the FROM instruction
("registry.access.redhat.com/ubi9/go-toolset:1.25.8") with an immutable
reference by pinning either a build-id suffix (e.g. append "-<build-id>" to the
tag) or an `@sha256`: digest; update the FROM instruction accordingly so the
builder stage uses a reproducible image and let Renovate re-pin on its next run
per the existing renovate.json rule.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2881179e-6743-4ab3-8d1e-1f741f478d18

📥 Commits

Reviewing files that changed from the base of the PR and between 00dd920 and 5e34aa5.

📒 Files selected for processing (12)

• .ci-operator.yaml
• .golangci.yaml
• Containerfile.external-dns-operator
• Dockerfile
• drift-cache/Dockerfile
• go.mod
• hack/golangci-lint.sh
• pkg/operator/controller/externaldns/deployment_test.go
• pkg/operator/controller/names.go
• renovate.json
• test/e2e/azure.go
• test/e2e/util.go

[alebedev87]

/lgtm
/approve

[alebedev87]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [alebedev87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alebedev87]

/jira refresh

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-79591, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@grzpiotrowski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@grzpiotrowski: Jira Issue OCPBUGS-79591: All pull requests linked via external trackers have merged:

• openshift/external-dns#151
• openshift/external-dns#152
• openshift/external-dns-operator#417
• openshift/external-dns-operator#420
• openshift/external-dns-operator#422

Jira Issue OCPBUGS-79591 has been moved to the MODIFIED state.

Details

In response to this:

• Bump Go version to v1.25.8
• Bump golangci-lint to v2.10.1 as a compatible version with Golang 1.25. Migrate .golangci.yaml to version 2.
• Resolve issues highlighted by new version of golangci-lint:

pkg/operator/controller/externaldns/deployment_test.go:4065:39  staticcheck  QF1008: could remove embedded field "VolumeSource" from selector
pkg/operator/controller/externaldns/deployment_test.go:4073:39  staticcheck  QF1008: could remove embedded field "VolumeSource" from selector
pkg/operator/controller/names.go:121:42                         staticcheck  QF1010: could convert argument to string
test/e2e/azure.go:124:19                                        staticcheck  QF1008: could remove embedded field "ZoneProperties" from selector
test/e2e/util.go:160:22                                         staticcheck  QF1008: could remove embedded field "ExternalDNSSourceUnion" from selector
test/e2e/util.go:186:22                                         staticcheck  QF1008: could remove embedded field "ExternalDNSSourceUnion" from selector

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.