CNTRLPLANE-3553: getRHELStream returns rhel-9 for pre-5.0 releases

[sdminonne]

Summary

• Update the dual-stream-rhel-nodepool enhancement to specify that getRHELStream returns "rhel-9" (instead of "") for the implicit pre-5.0 case.
• This aligns the enhancement with the implementation in openshift/hypershift#8730, where the change was requested by @enxebre during review.
• Returning a concrete stream name ensures downstream consumers like StreamForName() never receive an empty string, avoiding errors when the legacy StreamMetadata field is removed (> 5.3).
• Hash normalization in NewConfigGenerator keeps rolloutConfig.rhelStream empty when the resolved stream matches the version-derived default, so this does not cause spurious rollouts.

Test plan

• No code changes — enhancement text only.
• Verify the decision tree in the enhancement matches the implementation in stream.go:GetRHELStream.

🤖 Generated with Claude Code

[openshift-ci-robot]

@sdminonne: This pull request references CNTRLPLANE-3553 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• Update the dual-stream-rhel-nodepool enhancement to specify that getRHELStream returns "rhel-9" (instead of "") for the implicit pre-5.0 case.
• This aligns the enhancement with the implementation in openshift/hypershift#8730, where the change was requested by @enxebre during review.
• Returning a concrete stream name ensures downstream consumers like StreamForName() never receive an empty string, avoiding errors when the legacy StreamMetadata field is removed (> 5.3).
• Hash normalization in NewConfigGenerator keeps rolloutConfig.rhelStream empty when the resolved stream matches the version-derived default, so this does not cause spurious rollouts.

Test plan

• No code changes — enhancement text only.
• Verify the decision tree in the enhancement matches the implementation in stream.go:GetRHELStream.

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• enhancements/hypershift/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@sdminonne: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.