Skip to content

CNTRLPLANE-3367: Add KMS key rotation section#2041

Open
tjungblu wants to merge 1 commit into
openshift:masterfrom
tjungblu:kms_rotation_annotations_keycontroller
Open

CNTRLPLANE-3367: Add KMS key rotation section#2041
tjungblu wants to merge 1 commit into
openshift:masterfrom
tjungblu:kms_rotation_annotations_keycontroller

Conversation

@tjungblu

Copy link
Copy Markdown
Contributor

This covers an annotation-based approach to detect and migrate on external KEK changes in the KMS plugin architecture.

This design differs from #2036 by centralizing everything in the existing key controller instead of creating a new rotation controller.

This covers an annotation-based approach to detect and migrate on external KEK changes in the KMS plugin architecture.

This design differs from openshift#2036 by centralizing everything in the existing key controller instead of creating a new rotation controller.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 15, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 15, 2026

Copy link
Copy Markdown

@tjungblu: This pull request references CNTRLPLANE-3367 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This covers an annotation-based approach to detect and migrate on external KEK changes in the KMS plugin architecture.

This design differs from #2036 by centralizing everything in the existing key controller instead of creating a new rotation controller.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from sadasu June 15, 2026 15:18
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adambkaplan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested a review from shawn-hurley June 15, 2026 15:18
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

@tjungblu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ardaguclu

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants