STOR-3004: Rebase external-snapshotter to v8.6.0#224
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rvagner78: This pull request references STOR-3004 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Warning Review limit reached
More reviews will be available in 24 minutes and 36 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughA new ChangesDisable test-subtree Makefile target
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Around line 21-25: The test-subtree target currently unconditionally skips
execution, which removes the subtree sync verification from the main test flow.
Instead of always echoing a skip message in the test-subtree target, implement
explicit opt-out logic that allows the subtree test to run by default but can be
intentionally disabled via an environment variable or configuration flag. This
way the integration safety check executes in normal CI flows while still
permitting explicit bypass when needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 079cc836-4134-40bf-89bf-3fa5a2015566
📒 Files selected for processing (1)
Makefile
| # UPSTREAM: <carry>: disable test-subtree | ||
| .PHONY: test-subtree | ||
| test-subtree: | ||
| @ echo "### $@: skipped" | ||
|
|
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
test-subtree is silently bypassed in the main test path.
Line 21-Line 25 turns test-subtree into a no-op, and make test consumers (for example release-tools/go-modules-update.sh) will no longer verify subtree sync. This removes an integration safety check and can let subtree drift pass CI unnoticed.
Suggested fix (explicit opt-out instead of unconditional skip)
# UPSTREAM: <carry>: disable test-subtree
.PHONY: test-subtree
test-subtree:
- @ echo "### $@: skipped"
+ifeq ($(SKIP_SUBTREE_VERIFY),1)
+ @ echo "### $@: skipped (SKIP_SUBTREE_VERIFY=1)"
+else
+ @ echo; echo "### $@:"
+ @ ./release-tools/verify-subtree.sh release-tools
+endif📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # UPSTREAM: <carry>: disable test-subtree | |
| .PHONY: test-subtree | |
| test-subtree: | |
| @ echo "### $@: skipped" | |
| # UPSTREAM: <carry>: disable test-subtree | |
| .PHONY: test-subtree | |
| test-subtree: | |
| ifeq ($(SKIP_SUBTREE_VERIFY),1) | |
| @ echo "### $@: skipped (SKIP_SUBTREE_VERIFY=1)" | |
| else | |
| @ echo; echo "### $@:" | |
| @ ./release-tools/verify-subtree.sh release-tools | |
| endif | |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Makefile` around lines 21 - 25, The test-subtree target currently
unconditionally skips execution, which removes the subtree sync verification
from the main test flow. Instead of always echoing a skip message in the
test-subtree target, implement explicit opt-out logic that allows the subtree
test to run by default but can be intentionally disabled via an environment
variable or configuration flag. This way the integration safety check executes
in normal CI flows while still permitting explicit bypass when needed.
|
/test e2e-vsphere-csi |
3 similar comments
|
/test e2e-vsphere-csi |
|
/test e2e-vsphere-csi |
|
/test e2e-vsphere-csi |
|
/payload-job periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn |
|
@jsafrane: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0e0f6ca0-7081-11f1-9b54-4d44ad7b632f-0 |
rvagner78
force-pushed
the
rebase-v8.6.0-no-subtree-check
branch
from
c82d5c7 to
f12cafe
Compare
|
@rvagner78: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-job periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn |
|
@jsafrane: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a1e6b0b0-709e-11f1-99ce-b79f70804d53-0 |
|
@rvagner78, can you please squash |
…ge to be consistent with ART for 5.0 Reconciling with https://github.com/openshift-eng/ocp-build-data/tree/af322abdd1a4d7d0161a69a16369a0ab1748515a/images/ose-csi-snapshot-controller.yml Update OpenShift Dockerfiles to 5.0 and golang 1.26
The revert commit 56ba1dc breaks the verify-subtree check because it is a non-merge commit touching release-tools/. Disable verify-subtree until fixed in csi-release-tools (kubernetes-csi/csi-release-tools#305).
rvagner78
force-pushed
the
rebase-v8.6.0-no-subtree-check
branch
from
d204e21 to
9c6d440
Compare
|
/retest |
|
/payload-job periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn |
|
@jsafrane: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8fefd7f0-7162-11f1-9c68-0484aba73396-0 |
|
/payload-job periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn |
|
@rvagner78: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fed4f160-738c-11f1-8fb5-918f751d1e98-0 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, rvagner78 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/payload-job periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn |
|
@rvagner78: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a3b6b6b0-73c8-11f1-8992-cee1b00dbefd-0 |
|
/payload-job periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn |
|
@rvagner78: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/00522200-747e-11f1-96b2-5c71865ac053-0 |
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@rvagner78: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-csi |
4 participants
Upstream changelogs
Summary of changes
Diff to upstream:
Previous rebase: #202
cc @openshift/storage
Summary by CodeRabbit