OCPBUGS-84521: set terminationMessagePolicy on kube-rbac-proxy

[twoGiants]

Important

I am waiting for the openshift/origin#31362 to be merged so that I can perform the Jira steps for the CI bot in this repo to accept this PR.

Summary

Set terminationMessagePolicy: FallbackToLogsOnError on the kube-rbac-proxy container in the CAPI deployment. It was set to File, causing CI flakes in [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-machine-approver.

Additional Info

On main this was fixed by removing kube-rbac-proxy entirely (545d7e4883). On release-4.22 the sidecar is still needed, so we fix the policy instead.

Related: openshift/origin#31362 (removes the stale exemption for this namespace on main in openshift/origin)

Cherry-picking to release-4.21, release-4.20, and release-4.19. Not going further back as this is a Normal priority fix.

Fixes: https://issues.redhat.com/browse/OCPBUGS-84521

[openshift-ci-robot]

@twoGiants: This pull request references Jira Issue OCPBUGS-84521, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-84521 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport of 545d7e4883 to release-4.22.

The kube-rbac-proxy sidecar had terminationMessagePolicy: File instead of FallbackToLogsOnError, causing CI flakes in [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-machine-approver. Removing the sidecar in favour of metrics secureserving fixes the violation.

Additional Info

The fix is already on main since Jan 2026. This backport aligns release-4.22 with main.

Fixes: https://issues.redhat.com/browse/OCPBUGS-84521

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3699dc40-2bea-464b-883d-fcfe75c9f1d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[twoGiants]

/cc @mdbooth PTAL, thank you 🙏

[twoGiants]

/retest

[twoGiants]

Ok, all the checks are failing. Maybe this fix needs other past commits for this release -> so maybe I should only set the terminationMessagePolicy: FallbackToLogsOnError on the sidecar container instead of cherry-picking the commit 🤔

[twoGiants]

/test e2e-hypershift-aks

[openshift-ci]

@twoGiants: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mdbooth]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment