Skip to content

fix(spelling): replace check-spelling with crate-ci/typos for spell checking#3316

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
vparfonov:fix-spelling-action
Jun 22, 2026
Merged

fix(spelling): replace check-spelling with crate-ci/typos for spell checking#3316
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
vparfonov:fix-spelling-action

Conversation

@vparfonov

@vparfonov vparfonov commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

The check-spelling action (v0.0.26) is no longer maintained due to a security incident affecting the maintainer's account. Replace with crate-ci/typos (v1.33.1), a maintained Rust-based spell checker.

Error: Found security advisory for version 0.0.26: 'Sorry. https://github.com/jsoref/2026-06-16-credential-leak/blob/main/README.md'
Error: This is a fatal error ... asking Action Host to kill our workflow
Error: Process completed with exit code 200.

Changes:

  • Replace dead check-spelling@v0.0.26 with crate-ci/typos@v1.33.1
  • Add _typos.toml config with same word allowlist as previous setup
  • Fix typo: rate-lmiting → rate-limiting in Go source and generated docs

/cc
/assign @jcantrill

Links

  • Depending on PR(s):
  • GitHub issue:
  • JIRA:
  • Enhancement proposal:

The check-spelling action (v0.0.26) is no longer maintained due to a
security incident affecting the maintainer's account. Replace with
crate-ci/typos (v1.33.1), a maintained Rust-based spell checker.

Changes:
- Replace dead check-spelling@v0.0.26 with crate-ci/typos@v1.33.1
- Add _typos.toml config with same word allowlist as previous setup
- Make spell check non-blocking (continue-on-error: true) since code
  is open source and all issues are publicly visible anyway
- Fix typo: rate-lmiting → rate-limiting in Go source and generated docs

Note: typos does not support SARIF output, so findings will only appear
in workflow logs instead of GitHub's Security tab dashboard.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e7b28542-ff4a-4055-a76b-c8212bd2a177

📥 Commits

Reviewing files that changed from the base of the PR and between d2691e4 and 3ac1246.

📒 Files selected for processing (6)
  • .github/actions/spelling/_typos.toml
  • .github/workflows/spelling.yml
  • api/observability/v1/filter_api_audit_types.go
  • bundle/manifests/observability.openshift.io_clusterlogforwarders.yaml
  • config/crd/bases/observability.openshift.io_clusterlogforwarders.yaml
  • docs/reference/operator/api_observability_v1.adoc
 ________________________
< I am the one who bugs. >
 ------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

@openshift-ci openshift-ci Bot requested review from Clee2691 and alanconway June 19, 2026 15:21
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

@vparfonov

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@vparfonov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-using-bundle 3ac1246 link false /test e2e-using-bundle

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcantrill

Copy link
Copy Markdown
Contributor

/override "Spell checking"

@jcantrill

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@jcantrill: Overrode contexts on behalf of jcantrill: Spell checking

Details

In response to this:

/override "Spell checking"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2026
@jcantrill

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit ad383ac into openshift:master Jun 22, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants