OCPCLOUD-3541: Use feature gates consistently#603
Open
mdbooth wants to merge 6 commits into
Open
Conversation
Contributor
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (89)
📒 Files selected for processing (22)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (19)
WalkthroughThe PR updates platform helper return shapes, removes unsupported-platform fields from controllers, adds feature-gate-aware revision filtering, refactors machine-api-migration controller selection, and bumps OpenShift API dependencies across modules. ChangesPlatform and Feature-Gate Cleanup
Sequence Diagram(s)sequenceDiagram
participant main as machine-api-migration main()
participant getControllers
participant util.GetFeatureGates
participant allControllers
participant SetupWithManager
main->>getControllers: request controller map
getControllers->>util.GetFeatureGates: load feature gates
util.GetFeatureGates-->>getControllers: feature gates or error
alt controllers enabled
getControllers->>allControllers: build reconcilers
allControllers-->>main: controller map
main->>SetupWithManager: register each controller
else disabled or unsupported
getControllers-->>main: empty controller map
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (13 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
needs-rebase
openshift-ci
Bot
removed
the
needs-rebase
mdbooth
changed the title
|
@mdbooth: This pull request references OCPCLOUD-3541 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
Contributor
Author
|
/pipeline required |
Contributor
|
Scheduling tests matching the |
Contributor
Author
|
/pipeline auto |
Contributor
|
Pipeline controller notification The |
Contributor
|
Scheduling tests matching the |
Contributor
|
Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage. |
The revision controller now checks platform-specific CAPI feature gates when building the component list. Platform-specific provider profiles are only included when the corresponding feature gate is enabled.
Remove the IsSupportedPlatform/SupportedPlatform guards from the capi-operator entrypoint. The operator is deployed by CVO only when the ClusterAPIMachineManagement feature gate is enabled, so all controllers should run whenever the operator is deployed. Platform-specific provider selection is handled independently by the revision controller.
Contributor
|
@mdbooth: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
/test images |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes various hard-coded assumptions in the code about which
platforms are supported and uses feature gates exclusively for feature
enablement. Specifically:
regardless of whether the platform has support.
enabled.
enabling any platform-specific profiles.
featuregate and the per-platform MachineAPIMigration instead of hard-coding
AWS and OpenStack.
Summary by CodeRabbit