Skip to content

Revert golangci-lint bump to v2.7.2#744

Open
clcollins wants to merge 1 commit into
openshift:masterfrom
clcollins:revert-golangci-lint-bump
Open

Revert golangci-lint bump to v2.7.2#744
clcollins wants to merge 1 commit into
openshift:masterfrom
clcollins:revert-golangci-lint-bump

Conversation

@clcollins
Copy link
Copy Markdown
Member

@clcollins clcollins commented May 27, 2026

Summary

Why

The Go 1.26 upgrade is no longer needed — downstream operators are bumping down the kube components version instead. Reverting the golangci-lint bump to avoid shipping an unnecessary change.

This partially reverts 43f0781 (PR #743).

Changes

  • config/Dockerfile: version 2.12.22.7.2, restored original SHA256 checksum
  • boilerplate/openshift/golang-osd-operator/ensure.sh: version 2.12.22.7.2
  • boilerplate/openshift/golang-lint/ensure.sh: version 2.12.22.7.2

What is NOT reverted

  • boilerplate/openshift/golang-osd-operator/olm_pko_migration.py: The Optional[str] fix for Python 3.9 compatibility is kept — that was a genuine bug fix independent of the golangci-lint bump.

🤖 Created with assistance from Claude claude@anthropic.com

Summary by CodeRabbit

  • Chores
    • Updated Docker build configuration with new version pins and corresponding security verification checksums for the code linting tool used in the build pipeline. This change maintains build integrity, ensures consistent tooling across deployment environments, and refreshes security verification standards throughout the container image build process.

The Go 1.26 upgrade is no longer needed — downstream operators are
bumping down the kube components version instead. Revert golangci-lint
from v2.12.2 back to v2.7.2. The Python 3.9 compatibility fix from
PR openshift#743 is intentionally preserved.

This reverts the golangci-lint portion of 43f0781.

Created with assistance from Claude 🤖 <claude@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Christopher Collins <collins.christopher@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 49c6d69e-96e9-410f-8ff5-070ff71e1aad

📥 Commits

Reviewing files that changed from the base of the PR and between 43f0781 and c7cd213.

⛔ Files ignored due to path filters (2)
  • boilerplate/openshift/golang-lint/ensure.sh is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/ensure.sh is excluded by !boilerplate/**
📒 Files selected for processing (1)
  • config/Dockerfile

Walkthrough

golangci-lint build arguments in the Dockerfile are pinned to new versions: the version changes from 2.12.2 to 2.7.2, with a corresponding SHA-256 checksum update for tarball verification. Download and install logic remains unchanged.

Changes

Tooling Version Update

Layer / File(s) Summary
golangci-lint version and checksum
config/Dockerfile
Build arguments GOCILINT_VERSION and GOCILINT_SHA256SUM are pinned to new constants that will be used during tarball download and verification.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift/boilerplate#743: Modifies the same Dockerfile build arguments for golangci-lint version and checksum in the opposite direction.

Suggested labels

approved, tide/merge-method-squash, lgtm

Suggested reviewers

  • bergmannf
  • AlexSmithGH
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: reverting golangci-lint to v2.7.2, which is the primary objective of this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only Dockerfile and shell scripts to revert golangci-lint version; no test files are modified, making the Ginkgo test name stability check not applicable.
Test Structure And Quality ✅ Passed PR does not modify any Ginkgo test code; it only reverts golangci-lint versions in build configuration files, making this test quality check inapplicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are limited to version updates in Dockerfile and shell scripts, which are not subject to MicroShift test compatibility requirements.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR; all changes are infrastructure/tooling updates (Docker config and shell scripts).
Topology-Aware Scheduling Compatibility ✅ Passed This PR only updates build tool versions (golangci-lint) in Dockerfile and shell scripts. No deployment manifests, operator code, or scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies Docker/shell tool configs and Python utilities; no changes to Go test binaries, OTE code, or stdout/logging behavior that would violate the OTE binary stdout JSON contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR does not add any Ginkgo e2e tests; it only updates golangci-lint versions and shell scripts, making the custom check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from geowa4 and sam-nguyen7 May 27, 2026 01:31
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clcollins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant