Revert golangci-lint bump to v2.7.2#744
Conversation
The Go 1.26 upgrade is no longer needed — downstream operators are bumping down the kube components version instead. Revert golangci-lint from v2.12.2 back to v2.7.2. The Python 3.9 compatibility fix from PR openshift#743 is intentionally preserved. This reverts the golangci-lint portion of 43f0781. Created with assistance from Claude 🤖 <claude@anthropic.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Christopher Collins <collins.christopher@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Walkthrough
ChangesTooling Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clcollins The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Why
The Go 1.26 upgrade is no longer needed — downstream operators are bumping down the kube components version instead. Reverting the golangci-lint bump to avoid shipping an unnecessary change.
This partially reverts 43f0781 (PR #743).
Changes
config/Dockerfile: version2.12.2→2.7.2, restored original SHA256 checksumboilerplate/openshift/golang-osd-operator/ensure.sh: version2.12.2→2.7.2boilerplate/openshift/golang-lint/ensure.sh: version2.12.2→2.7.2What is NOT reverted
boilerplate/openshift/golang-osd-operator/olm_pko_migration.py: TheOptional[str]fix for Python 3.9 compatibility is kept — that was a genuine bug fix independent of the golangci-lint bump.🤖 Created with assistance from Claude claude@anthropic.com
Summary by CodeRabbit