[Fix] Make HTTP status assertion protocol-independent - #5623
Merged
penghuo merged 1 commit intoJul 14, 2026
Merged
Conversation
Signed-off-by: Kai Huang <ahkcs@amazon.com>
ahkcs
requested review from
LantaoJin,
RyanL1997,
Swiddis,
acarbonetto,
anirudha,
dai-chen,
joshuali925,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
songkant-aws,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
July 14, 2026 18:40
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
penghuo
approved these changes
Jul 14, 2026
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Kai Huang <ahkcs@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the protocol-specific
ResponseExceptionmessage check with an assertion on the numeric HTTP status code. Security-enabled clusters can negotiate HTTP/2, which caused this test to fail despite correctly receiving HTTP 400.Related Issues
Resolves #5620
Testing
./gradlew :integ-test:spotlessJavaCheck :integ-test:compileTestJava./gradlew :integ-test:integTest -Dsecurity.enabled=true --tests org.opensearch.sql.calcite.remote.CalcitePPLCaseFunctionIT.testCaseWithIncompatibleBranchTypesRejectsCleanlyCheck List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.