Add false_allow_templates to DynamicMapping - #1178
Open
Truta446 wants to merge 1 commit into
Open
Conversation
Truta446
requested review from
Tokesh,
VachaShah,
Xtansia,
aabeshov,
harshavamsi,
karenyrx,
lucy66hw,
sachetalva and
sean-
as code owners
July 23, 2026 15:02
Signed-off-by: Juan Versolato Lopes <juan.versolato@atlas.red>
Truta446
force-pushed
the
feat/dynamic-mapping-false-allow-templates
branch
from
July 23, 2026 15:04
4b5e625 to
c056152
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
false_allow_templatesvalue to theDynamicMappingschema.OpenSearch's
dynamicmapping parameter acceptsfalse_allow_templates(new fields are only indexed when they match a dynamic template, otherwise they are not indexed), but the spec'sDynamicMappingenum was missing it — it only listedfalse,strict,strict_allow_templates,true, and boolean. As a result, generated clients reject the value at the type level even though it works at runtime.The value was introduced in OpenSearch 3.3.0 (opensearch-project/OpenSearch#19065), so the added integration test case is gated with
version: '>= 3.3', mirroring the existingstrict_allow_templatescase.Reported downstream in the JS client: .
Issues Resolved
Fixes the missing
false_allow_templatesvalue inDynamicMapping.Changes
spec/schemas/_common.mapping.yaml: addfalse_allow_templatesto theDynamicMappingstring enum.tests/default/indices/mapping/mapping.yaml: add an integration test settingdynamic: false_allow_templates(gated>= 3.3).CHANGELOG.md: changelog entry.Check List
npm run lint:specpasses;npm run mergesucceeds and the bundled spec includes the value).--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.