Specify usage of upsert key in Bulk operations - #11506
Conversation
Signed-off-by: Karen X <karenxyr@gmail.com>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Karen X <karenxyr@gmail.com>
Signed-off-by: Karen X <karenxyr@gmail.com>
Signed-off-by: Karen X <karenxyr@gmail.com>
|
hi @kolchfa-aws would you be able to hep take a look at this PR? Thanks! |
Signed-off-by: Karen X <karenxyr@gmail.com>
kolchfa-aws
left a comment
There was a problem hiding this comment.
Thank you, @karenyrx! Please see my comments and let me know if you have any questions.
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Karen X <karenxyr@gmail.com>
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Nathan Bower <nbower@amazon.com>
* Specify usage of `upsert` key in Bulk operations Signed-off-by: Karen X <karenxyr@gmail.com> * update Signed-off-by: Karen X <karenxyr@gmail.com> * update 2 Signed-off-by: Karen X <karenxyr@gmail.com> * Update bulk.md Signed-off-by: Karen X <karenxyr@gmail.com> * update scripted upsert too Signed-off-by: Karen X <karenxyr@gmail.com> * update scripted upsert Signed-off-by: Karen X <karenxyr@gmail.com> * doc_as_upsert Signed-off-by: Karen X <karenxyr@gmail.com> * Apply suggestions from code review Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Karen X <karenxyr@gmail.com> * Tab over code samples so numbered list shows correct numbers Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Tab over code examples in the upsert section Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> * Update _api-reference/document-apis/bulk.md Signed-off-by: Nathan Bower <nbower@amazon.com> --------- Signed-off-by: Karen X <karenxyr@gmail.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Nathan Bower <nbower@amazon.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit fc5976c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
| { "update": { "_index": "movies", "_id": "tt0816711" } } | ||
| { "doc" : { "title": "World War Z" }, "doc_as_upsert": true } | ||
| ``` | ||
| 1. Specify the document to update (when it exists) in the `doc` field, the document to insert (when it doesn't exist) in the `upsert` field, and leave `doc_as_update` set to `false`: |
…ant (#12865) doc_as_update is not used by neither OpenSearch [1] nor Elastic [2]. [1]: https://github.com/search?q=org%3Aopensearch-project%20doc_as_update&type=code [2]: https://github.com/search?q=repo%3Aelastic%2Fecs%20doc_as_update&type=code Introduced in: #11506 Introduced in: fc5976c Signed-off-by: Robin Schneider <ro.schneider@senec.com>
…ant (#12865) (#12867) doc_as_update is not used by neither OpenSearch [1] nor Elastic [2]. [1]: https://github.com/search?q=org%3Aopensearch-project%20doc_as_update&type=code [2]: https://github.com/search?q=repo%3Aelastic%2Fecs%20doc_as_update&type=code Introduced in: #11506 Introduced in: fc5976c (cherry picked from commit 9f78096) Signed-off-by: Robin Schneider <ro.schneider@senec.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Robin Schneider <ro.schneider@senec.com>
Description
The
upsertkey is supported in the spec for update operations: https://github.com/opensearch-project/opensearch-api-specification/blob/main/spec/schemas/_core.bulk.yaml#L121 , yet is not mentioned in the documentation anywhere.Specify its usage in the documentation as well.
Issues Resolved
General fix
Version
All
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.