Fix SystemFunctionsIT.testTypeofArithmetic for int-operand widening by aasom143 · Pull Request #22466 · opensearch-project/OpenSearch

aasom143 · 2026-07-14T14:29:20Z

Description

SystemFunctionsIT.testTypeofArithmetic has been failing consistently on main:

Value mismatch for query: source=calcs | where key='key00' | head 1 | eval t = typeof(int0 * 2) | fields t
expected:<[]INT> but was:<[BIG]INT>

This is an expected behavior change, not a regression. opensearch-project/sql#5603 widens narrow integer operands (byte/short/int) before +, -, * so the result cannot overflow the inferred type. As a result, int0 * 2 now infers as BIGINT instead of INT, and typeof(int0 * 2) correctly returns "BIGINT". The QA assertion was written against the old (overflow-prone) INT inference and needs to reflect the new, correct type.

Change

Update the typeof(int0 * 2) assertion (and its comment) to expect "BIGINT". Test-only; no production code change.

Testing

./gradlew ':sandbox:qa:analytics-engine-rest:integTest' --tests 'org.opensearch.analytics.qa.SystemFunctionsIT.testTypeofArithmetic' (sandbox, JDK 25).

Check List

Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions · 2026-07-14T14:30:15Z

PR Reviewer Guide 🔍

(Review updated until commit `4ac064f`)

Here are some key observations to aid the review process:

🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review Empty test body The `testTypeofArithmetic` method body only contains a single `assertFirstRowString` call; however, in the diff the previous `assertFirstRowString` call was removed (in the `__old hunk__`) and now only the new one is present. Verify the test method still asserts what is intended — it now only checks that `typeof(int0 * 2)` returns `BIGINT` and no longer verifies the pre-existing INT case. If the intent was to keep both cases (e.g., also assert on a non-widening arithmetic form), the assertion coverage has been reduced. public void testTypeofArithmetic() throws IOException { assertFirstRowString(oneRow("key00") + "\| eval t = typeof(int0 * 2) \| fields t", "BIGINT"); }

github-actions · 2026-07-14T15:24:39Z

✅ Gradle check result for 527e93f: SUCCESS

codecov · 2026-07-14T15:25:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.41%. Comparing base (c93e9af) to head (4ac064f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #22466      +/-   ##
============================================
- Coverage     73.43%   73.41%   -0.03%     
+ Complexity    76472    76452      -20     
============================================
  Files          6104     6104              
  Lines        346573   346573              
  Branches      49886    49886              
============================================
- Hits         254514   254435      -79     
- Misses        71798    71925     +127     
+ Partials      20261    20213      -48

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-07-14T15:39:38Z

Persistent review updated to latest commit 7defc3e

github-actions · 2026-07-14T16:33:29Z

✅ Gradle check result for 7defc3e: SUCCESS

github-actions · 2026-07-16T05:46:25Z

Persistent review updated to latest commit 594ed79

github-actions · 2026-07-16T05:50:35Z

❌ Gradle check result for 594ed79: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-07-16T17:34:32Z

Persistent review updated to latest commit 8821e4b

github-actions · 2026-07-16T19:35:39Z

❌ Gradle check result for 8821e4b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-07-17T06:46:52Z

Persistent review updated to latest commit 7b7b2bf

github-actions · 2026-07-17T07:28:50Z

Persistent review updated to latest commit ec0e9a8

github-actions · 2026-07-17T08:22:37Z

❌ Gradle check result for ec0e9a8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-07-17T08:50:53Z

Persistent review updated to latest commit aa6f7cd

github-actions · 2026-07-17T09:45:18Z

✅ Gradle check result for aa6f7cd: SUCCESS

github-actions · 2026-07-17T10:56:39Z

Persistent review updated to latest commit fcef072

github-actions · 2026-07-17T11:26:47Z

❌ Gradle check result for fcef072: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2026-07-17T12:14:12Z

Persistent review updated to latest commit a3af830

opensearch-project/sql#5603 widens narrow integer operands (byte/short/int) before +, -, * so the result cannot overflow the inferred type, which makes `int0 * 2` infer as BIGINT instead of INT. Update the typeof assertion (and its comment) to expect "BIGINT", matching the merged SQL behavior. This IT has been failing consistently on main since that grammar/lowering change landed. Test-only change.. Signed-off-by: Kai Huang <ahkcs@amazon.com> Update plan shape goldens for int-operand widening to BIGINT The int-operand widening fix (aa6f7cd) changed arithmetic expressions to cast integer operands to BIGINT before addition or subtraction. Update the q30 and q36 golden files to reflect the new plan shapes in both logical (nested ANNOTATED_PROJECT_EXPR with CAST(:BIGINT)) and physical (Int32 → Int64, CAST(... AS Int64)) layers. Signed-off-by: Somesh Gupta <guptasom@amazon.com>

github-actions · 2026-07-17T12:56:57Z

Persistent review updated to latest commit 4ac064f

github-actions · 2026-07-17T13:57:07Z

✅ Gradle check result for 4ac064f: SUCCESS

aasom143 requested a review from a team as a code owner July 14, 2026 14:29

aasom143 force-pushed the build-fix branch from 527e93f to 7defc3e Compare July 14, 2026 15:38

aasom143 force-pushed the build-fix branch from 7defc3e to 594ed79 Compare July 16, 2026 05:45

aasom143 force-pushed the build-fix branch from 594ed79 to 8821e4b Compare July 16, 2026 17:33

aasom143 force-pushed the build-fix branch from 8821e4b to 7b7b2bf Compare July 17, 2026 06:45

aasom143 force-pushed the build-fix branch from 7b7b2bf to ec0e9a8 Compare July 17, 2026 07:27

aasom143 force-pushed the build-fix branch from ec0e9a8 to aa6f7cd Compare July 17, 2026 08:49

aasom143 force-pushed the build-fix branch from fcef072 to a3af830 Compare July 17, 2026 12:13

aasom143 force-pushed the build-fix branch from a3af830 to 4ac064f Compare July 17, 2026 12:55

ahkcs approved these changes Jul 17, 2026

View reviewed changes

bharath-techie approved these changes Jul 20, 2026

View reviewed changes

bharath-techie merged commit 39fe516 into opensearch-project:main Jul 20, 2026
16 checks passed

aasom143 deleted the build-fix branch July 20, 2026 11:38

Uh oh!

Conversation

aasom143 commented Jul 14, 2026

Description

Change

Testing

Check List

Uh oh!

github-actions Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Reviewer Guide 🔍

(Review updated until commit 4ac064f)

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

codecov Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jul 14, 2026 •

edited

Loading

(Review updated until commit `4ac064f`)

codecov Bot commented Jul 14, 2026 •

edited

Loading