chore(deps): dompurify 3.4.12, adm-zip 0.6.0 - #12477
Conversation
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit 72476c3. ⛔ Hard block: Issues at High severity or above will block this PR from merging.
The table above displays the top 10 most important findings. Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
✅ All unit and integration tests passing
|
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12477 +/- ##
===========================================
- Coverage 61.58% 0 -61.59%
===========================================
Files 4995 0 -4995
Lines 137542 0 -137542
Branches 23901 0 -23901
===========================================
- Hits 84707 0 -84707
+ Misses 46692 0 -46692
+ Partials 6143 0 -6143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| env: | ||
| START_CMD: 'node scripts/opensearch_dashboards --dev --no-base-path --no-watch --savedObjects.maxImportPayloadBytes=10485760 --server.maxPayloadBytes=1759977 --logging.json=false --data.search.aggs.shardDelay.enabled=true --csp.warnLegacyBrowsers=false --uiSettings.overrides["query:enhancements:enabled"]=true --uiSettings.overrides[''home:useNewHomePage'']=true --data_source.enabled=true --workspace.enabled=true --opensearch.ignoreVersionMismatch=true' | ||
| OPENSEARCH_SNAPSHOT_CMD: '/bin/bash -c "./opensearch-${{ env.LATEST_VERSION }}/opensearch-tar-install.sh &"' | ||
| OPENSEARCH_SNAPSHOT_CMD: '/bin/bash -c "./opensearch-3.4.0/opensearch-tar-install.sh &"' |
There was a problem hiding this comment.
Yes, it's error existing in main visible on CI logs, top-level env variables can't be resolved inside jobs env variables.
There was a problem hiding this comment.
I see, that seems was introduced by https://github.com/opensearch-project/OpenSearch-Dashboards/pull/12413/changes, can you share a example error CI logs? maybe link to the CI outputs
There was a problem hiding this comment.
It's on description (Line: 46, Col: 32): Unrecognized named-value: 'env'. Located at position 1 within expression: env.LATEST_VERSION
Description
Update dependencies to address CVEs
Fix cypress_workflow_with_s3, top-level env reference in jobs env is not allowed
(Line: 46, Col: 32): Unrecognized named-value: 'env'. Located at position 1 within expression: env.LATEST_VERSION
Issues Resolved
closes #12473
closes #12419
after merge pull request below can be closed as obsolete:
#12474
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration