Skip to content

chore(deps): dompurify 3.4.12, adm-zip 0.6.0 - #12477

Open
tomkdgun wants to merge 4 commits into
opensearch-project:mainfrom
tomkdgun:dumpurify_tk
Open

chore(deps): dompurify 3.4.12, adm-zip 0.6.0#12477
tomkdgun wants to merge 4 commits into
opensearch-project:mainfrom
tomkdgun:dumpurify_tk

Conversation

@tomkdgun

@tomkdgun tomkdgun commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

Update dependencies to address CVEs

Fix cypress_workflow_with_s3, top-level env reference in jobs env is not allowed
(Line: 46, Col: 32): Unrecognized named-value: 'env'. Located at position 1 within expression: env.LATEST_VERSION

Issues Resolved

closes #12473
closes #12419

after merge pull request below can be closed as obsolete:
#12474

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 72476c3.

Hard block: Issues at High severity or above will block this PR from merging.

PathLineSeverityDescription
package.json143highDependency change: new resolution entry '**/adm-zip' pinned to '^0.6.0' added. This is a major version bump (0.5.x → 0.6.0) for a ZIP-handling library with broad glob scope ('**/'). Maintainers must verify artifact authenticity at registry.
yarn.lock6576highDependency change: adm-zip resolved version changed from 0.5.18 to 0.6.0 with new integrity hash. Supply chain rule mandates flagging — verify the published artifact at registry.yarnpkg.com matches expectations.
package.json243highDependency change: dompurify bumped from '^3.4.11' to '^3.4.12'. This is a security-critical sanitization library; any version change must be verified to ensure the published package has not been tampered with.
yarn.lock9695highDependency change: dompurify resolved version changed from 3.4.11 to 3.4.12 with new integrity hash. Being the primary XSS-prevention library in the project, maintainers should verify the new release notes and artifact integrity.
packages/osd-utils/package.json15highDependency change: ip-address bumped from '^10.2.0' to '^10.3.1'. Used in network/CIDR logic; maintainers must verify artifact authenticity at registry.
yarn.lock12519highDependency change: ip-address resolved version changed from 10.2.0 to 10.3.1 with new integrity hash. The accompanying test change (updated error message) is consistent with a real upstream change, but artifact authenticity still requires verification.
yarn.lock7626highDependency change: brace-expansion bumped from 5.0.7 to 5.0.8 in lockfile only (no corresponding package.json change visible). Transitive-only lockfile bumps can indicate dependency confusion or silent substitution; maintainers should verify which direct dependency pulled the new version.
.github/workflows/cypress_workflow_with_s3.yml46lowCI workflow changed from using dynamic env variable '${{ env.LATEST_VERSION }}' to hardcoded version '3.4.0' for the OpenSearch snapshot install command. This pins CI to a specific version, preventing automatic pickup of newer/patched releases, but has plausible intent (test reproducibility).

The table above displays the top 10 most important findings.

Total: 8 | Critical: 0 | High: 7 | Medium: 0 | Low: 1


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

✅ All unit and integration tests passing

🔗 Workflow run · commit 72476c31e32f7a3e85271235941bfd43507137a3

tomkdgun added 2 commits July 28, 2026 12:05
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
tomkdgun added 2 commits July 28, 2026 13:40
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (7782a80) to head (72476c3).
⚠️ Report is 354 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12477       +/-   ##
===========================================
- Coverage   61.58%        0   -61.59%     
===========================================
  Files        4995        0     -4995     
  Lines      137542        0   -137542     
  Branches    23901        0    -23901     
===========================================
- Hits        84707        0    -84707     
+ Misses      46692        0    -46692     
+ Partials     6143        0     -6143     
Flag Coverage Δ
Linux_1 ?
Linux_2 ?
Linux_3 ?
Linux_4 ?
Linux_5 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

env:
START_CMD: 'node scripts/opensearch_dashboards --dev --no-base-path --no-watch --savedObjects.maxImportPayloadBytes=10485760 --server.maxPayloadBytes=1759977 --logging.json=false --data.search.aggs.shardDelay.enabled=true --csp.warnLegacyBrowsers=false --uiSettings.overrides["query:enhancements:enabled"]=true --uiSettings.overrides[''home:useNewHomePage'']=true --data_source.enabled=true --workspace.enabled=true --opensearch.ignoreVersionMismatch=true'
OPENSEARCH_SNAPSHOT_CMD: '/bin/bash -c "./opensearch-${{ env.LATEST_VERSION }}/opensearch-tar-install.sh &"'
OPENSEARCH_SNAPSHOT_CMD: '/bin/bash -c "./opensearch-3.4.0/opensearch-tar-install.sh &"'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change by intention?

@tomkdgun tomkdgun Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's error existing in main visible on CI logs, top-level env variables can't be resolved inside jobs env variables.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, that seems was introduced by https://github.com/opensearch-project/OpenSearch-Dashboards/pull/12413/changes, can you share a example error CI logs? maybe link to the CI outputs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on description (Line: 46, Col: 32): Unrecognized named-value: 'env'. Located at position 1 within expression: env.LATEST_VERSION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CVE-2026-66010 (Medium) detected in dompurify-3.4.11.tgz CVE-2026-39244 (High) detected in adm-zip-0.5.18.tgz

2 participants