LLM Models#212
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #212 +/- ##
==========================================
+ Coverage 98.70% 98.74% +0.04%
==========================================
Files 11 12 +1
Lines 1843 1890 +47
Branches 180 182 +2
==========================================
+ Hits 1819 1866 +47
Misses 5 5
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sadrasabouri
left a comment
There was a problem hiding this comment.
Thanks for your efforts.
I have some minor comments.
| @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| - `MemorError` class | |||
| ### Changed | |||
| - `LLMModel` enum updated | |||
There was a problem hiding this comment.
should add something about the fact that LLMModel is no longer an Enum.
There was a problem hiding this comment.
This one should be updated to something like LLMModel.<provider>.<member> | str.
| @@ -23,7 +24,7 @@ class Response(Message): | |||
| Response class. | |||
|
|
|||
| >>> from memor import Response, Role | |||
There was a problem hiding this comment.
should add import LLMModel as well.
Reference Issues/PRs
What does this implement/fix? Explain your changes
llm_models.pyfileLLMModelenum updatedREADME.mdupdatedAny other comments?