Skip to content

LLM Models#212

Merged
sadrasabouri merged 15 commits into
devfrom
llm-models
May 29, 2026
Merged

LLM Models#212
sadrasabouri merged 15 commits into
devfrom
llm-models

Conversation

@sepandhaghighi
Copy link
Copy Markdown
Member

@sepandhaghighi sepandhaghighi commented May 23, 2026

Reference Issues/PRs

What does this implement/fix? Explain your changes

  • LLM models moved to llm_models.py file
  • LLMModel enum updated
  • README.md updated
  • Test system modified

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this May 23, 2026
@sepandhaghighi sepandhaghighi added enhancement New feature or request refactoring labels May 23, 2026
@sepandhaghighi sepandhaghighi added this to the memor v1.2 milestone May 23, 2026
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 23, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (33d0067) to head (1888278).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #212      +/-   ##
==========================================
+ Coverage   98.70%   98.74%   +0.04%     
==========================================
  Files          11       12       +1     
  Lines        1843     1890      +47     
  Branches      180      182       +2     
==========================================
+ Hits         1819     1866      +47     
  Misses          5        5              
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi sepandhaghighi marked this pull request as ready for review May 24, 2026 12:49
Copy link
Copy Markdown
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts.
I have some minor comments.

Comment thread CHANGELOG.md Outdated
@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- `MemorError` class
### Changed
- `LLMModel` enum updated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add something about the fact that LLMModel is no longer an Enum.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 1888278

Comment thread README.md Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be updated to something like LLMModel.<provider>.<member> | str.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in e23b45d

Comment thread memor/response.py Outdated
@@ -23,7 +24,7 @@ class Response(Message):
Response class.

>>> from memor import Response, Role
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add import LLMModel as well.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 4346260

Copy link
Copy Markdown
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadrasabouri sadrasabouri merged commit 7217bda into dev May 29, 2026
25 checks passed
@sadrasabouri sadrasabouri deleted the llm-models branch May 29, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants