Refactor models list#39
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #39 +/- ##
==========================================
- Coverage 98.73% 94.12% -4.60%
==========================================
Files 9 10 +1
Lines 235 187 -48
Branches 26 21 -5
==========================================
- Hits 232 176 -56
- Misses 2 7 +5
- Partials 1 4 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Documentation | 8 minor |
| CodeStyle | 2 minor |
🟢 Metrics -3 complexity · 0 duplication
Metric Results Complexity -3 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
@sepandhaghighi, I revised the changes that were proposed in this PR. The summary of changes and the main idea/motivation behind them are presented below. It might look like more than a single PR, so feel free to let me know to split it into different PRs. New ArchitectureMotivationKeeping registry info of all the models centralized to be able to build on it for future developments. File Overview
Dependency GraphRuntime FlowBefore → After
Adding a New ModelAll three aspects (params, equation, validation) are added in Then add to from .name import NameModelChecklist
|
|
Requires more thought on how to implement it according to the best practices. It will be postponed to version 0.5. |
params.pyabstractmethods inDrugReleaseModelusing configs from models registries1for the Entire releasable amount (M_0/M) in the respective modelsblack